Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2411743002: [inspector] include test/inspector.gyp only when inspector is enabled (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] include test/inspector.gyp only when inspector is enabled BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Committed: https://crrev.com/e46f1016f2d0be6a33c65763bf9ad48659ae091b Cr-Commit-Position: refs/heads/master@{#40177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M gypfiles/all.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kozy
Please take a look!
4 years, 2 months ago (2016-10-11 14:36:29 UTC) #3
Michael Achenbach
LGTM
4 years, 2 months ago (2016-10-11 14:46:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411743002/1
4 years, 2 months ago (2016-10-11 14:47:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 14:59:26 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 14:59:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e46f1016f2d0be6a33c65763bf9ad48659ae091b
Cr-Commit-Position: refs/heads/master@{#40177}

Powered by Google App Engine
This is Rietveld 408576698