Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/test/data/push_messaging/push_test.js

Issue 2411733002: Check the format of an applicationServerKey when used to register a push subscription. (Closed)
Patch Set: Removed unneeded file Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/push_messaging/push_test.js
diff --git a/chrome/test/data/push_messaging/push_test.js b/chrome/test/data/push_messaging/push_test.js
index 9a1336067db956d91f95e0205b977dca81d08427..99b4d8f4ed87beb7c9c6ccf61b808f5a50dd8b57 100644
--- a/chrome/test/data/push_messaging/push_test.js
+++ b/chrome/test/data/push_messaging/push_test.js
@@ -112,7 +112,7 @@ function documentSubscribePush() {
}).catch(sendErrorToTest);
}
-function documentSubscribePushBadKey() {
+function documentSubscribePushLongKey() {
navigator.serviceWorker.ready.then(function(swRegistration) {
var invalidApplicationServerKey = new Uint8Array(300);
invalidApplicationServerKey.fill('0x05', 1, 300);
@@ -125,6 +125,39 @@ function documentSubscribePushBadKey() {
}).catch(sendErrorToTest);
}
+function documentSubscribePushShortKey() {
+ navigator.serviceWorker.ready.then(function(swRegistration) {
+ pushSubscriptionOptions.applicationServerKey = new Uint8Array().buffer;
+ return swRegistration.pushManager.subscribe(pushSubscriptionOptions)
+ .then(function(subscription) {
+ sendResultToTest(subscription.endpoint);
+ });
+ }).catch(sendErrorToTest);
+}
+function documentSubscribePushNonNumericKey() {
+ navigator.serviceWorker.ready.then(function(swRegistration) {
+ const invalidApplicationServerKey = Uint8Array.from("01234a56789");
+ pushSubscriptionOptions.applicationServerKey =
+ invalidApplicationServerKey.buffer;
+ return swRegistration.pushManager.subscribe(pushSubscriptionOptions)
+ .then(function(subscription) {
+ sendResultToTest(subscription.endpoint);
+ });
+ }).catch(sendErrorToTest);
+}
+
+function documentSubscribePushValidSenderId() {
+ navigator.serviceWorker.ready.then(function(swRegistration) {
+ let validApplicationServerKey = "123456789";
+ pushSubscriptionOptions.applicationServerKey =
+ validApplicationServerKey.buffer;
+ return swRegistration.pushManager.subscribe(pushSubscriptionOptions)
+ .then(function(subscription) {
+ sendResultToTest(subscription.endpoint);
+ });
+ }).catch(sendErrorToTest);
+}
+
function workerSubscribePush() {
// Send the message to the worker for it to subscribe
navigator.serviceWorker.controller.postMessage({command: 'workerSubscribe'});

Powered by Google App Engine
This is Rietveld 408576698