Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9152)

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 2411733002: Check the format of an applicationServerKey when used to register a push subscription. (Closed)
Patch Set: More formatting Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/push_messaging/push_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
index c7ee2155c33fedb96698bc0c97ee59a4d21bd150..253aa117fe7319e886bafbf0e1a0960ae5cd8866 100644
--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
@@ -447,21 +447,6 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
GetAppIdentifierForServiceWorkerRegistration(0LL);
}
-IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, SubscribeFailureBadKey) {
- std::string script_result;
-
- ASSERT_TRUE(RunScript("registerServiceWorker()", &script_result));
- ASSERT_EQ("ok - service worker registered", script_result);
-
- ASSERT_NO_FATAL_FAILURE(RequestAndAcceptPermission());
-
- ASSERT_TRUE(RunScript("documentSubscribePushBadKey()", &script_result));
- EXPECT_EQ(
- "InvalidAccessError - Failed to execute 'subscribe' on 'PushManager': "
- "The provided applicationServerKey is not valid.",
- script_result);
-}
-
IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
SubscribeFailureNotificationsBlocked) {
std::string script_result;
« no previous file with comments | « no previous file | chrome/test/data/push_messaging/push_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698