Index: src/effects/gradients/SkGradientShader.cpp |
diff --git a/src/effects/gradients/SkGradientShader.cpp b/src/effects/gradients/SkGradientShader.cpp |
index 3547fbec94f4e372c5ee3dc70e7c0bd4a03effdd..dfd4777ade65b7e99596ec4ae4a1693b69e121ca 100644 |
--- a/src/effects/gradients/SkGradientShader.cpp |
+++ b/src/effects/gradients/SkGradientShader.cpp |
@@ -203,6 +203,23 @@ void SkGradientShaderBase::flatten(SkWriteBuffer& buffer) const { |
buffer.writeMatrix(fPtsToUnit); |
} |
+SkGradientShaderBase::ColorType SkGradientShaderBase::getGradientColorType(SkColor colors[3]) const { |
+ if (fColorCount <= 3) { |
+ memcpy(colors, fOrigColors, fColorCount * sizeof(SkColor)); |
+ } |
+ |
+ if (SkShader::kClamp_TileMode == fTileMode) { |
+ if (2 == fColorCount) { |
+ return kTwo_ColorType; |
+ } else if (3 == fColorCount && |
+ (SkScalarAbs( |
+ SkFixedToScalar(fRecs[1].fPos) - SK_ScalarHalf) < SK_Scalar1 / 1000)) { |
+ return kThree_ColorType; |
+ } |
+ } |
+ return kTexture_ColorType; |
+} |
+ |
bool SkGradientShaderBase::isOpaque() const { |
return fColorsAreOpaque; |
} |
@@ -841,13 +858,13 @@ GrGLGradientEffect::~GrGLGradientEffect() { } |
void GrGLGradientEffect::emitUniforms(GrGLShaderBuilder* builder, EffectKey key) { |
- if (GrGradientEffect::kTwo_ColorType == ColorTypeFromKey(key)) { // 2 Color case |
+ if (SkGradientShaderBase::kTwo_ColorType == ColorTypeFromKey(key)) { // 2 Color case |
fColorStartUni = builder->addUniform(GrGLShaderBuilder::kFragment_Visibility, |
kVec4f_GrSLType, "GradientStartColor"); |
fColorEndUni = builder->addUniform(GrGLShaderBuilder::kFragment_Visibility, |
kVec4f_GrSLType, "GradientEndColor"); |
- } else if (GrGradientEffect::kThree_ColorType == ColorTypeFromKey(key)){ // 3 Color Case |
+ } else if (SkGradientShaderBase::kThree_ColorType == ColorTypeFromKey(key)){ // 3 Color Case |
fColorStartUni = builder->addUniform(GrGLShaderBuilder::kFragment_Visibility, |
kVec4f_GrSLType, "GradientStartColor"); |
fColorMidUni = builder->addUniform(GrGLShaderBuilder::kFragment_Visibility, |
@@ -889,7 +906,7 @@ void GrGLGradientEffect::setData(const GrGLUniformManager& uman, |
const GrGradientEffect& e = drawEffect.castEffect<GrGradientEffect>(); |
- if (GrGradientEffect::kTwo_ColorType == e.getColorType()){ |
+ if (SkGradientShaderBase::kTwo_ColorType == e.getColorType()){ |
if (GrGradientEffect::kBeforeInterp_PremulType == e.getPremulType()) { |
set_mul_color_uni(uman, fColorStartUni, e.getColors(0)); |
@@ -899,7 +916,7 @@ void GrGLGradientEffect::setData(const GrGLUniformManager& uman, |
set_color_uni(uman, fColorEndUni, e.getColors(1)); |
} |
- } else if (GrGradientEffect::kThree_ColorType == e.getColorType()){ |
+ } else if (SkGradientShaderBase::kThree_ColorType == e.getColorType()){ |
if (GrGradientEffect::kBeforeInterp_PremulType == e.getPremulType()) { |
set_mul_color_uni(uman, fColorStartUni, e.getColors(0)); |
@@ -926,9 +943,9 @@ GrGLEffect::EffectKey GrGLGradientEffect::GenBaseGradientKey(const GrDrawEffect& |
EffectKey key = 0; |
- if (GrGradientEffect::kTwo_ColorType == e.getColorType()) { |
+ if (SkGradientShaderBase::kTwo_ColorType == e.getColorType()) { |
key |= kTwoColorKey; |
- } else if (GrGradientEffect::kThree_ColorType == e.getColorType()){ |
+ } else if (SkGradientShaderBase::kThree_ColorType == e.getColorType()){ |
key |= kThreeColorKey; |
} |
@@ -945,7 +962,7 @@ void GrGLGradientEffect::emitColor(GrGLShaderBuilder* builder, |
const char* outputColor, |
const char* inputColor, |
const TextureSamplerArray& samplers) { |
- if (GrGradientEffect::kTwo_ColorType == ColorTypeFromKey(key)){ |
+ if (SkGradientShaderBase::kTwo_ColorType == ColorTypeFromKey(key)){ |
builder->fsCodeAppendf("\tvec4 colorTemp = mix(%s, %s, clamp(%s, 0.0, 1.0));\n", |
builder->getUniformVariable(fColorStartUni).c_str(), |
builder->getUniformVariable(fColorEndUni).c_str(), |
@@ -961,7 +978,7 @@ void GrGLGradientEffect::emitColor(GrGLShaderBuilder* builder, |
builder->fsCodeAppendf("\t%s = %s;\n", outputColor, |
(GrGLSLExpr4(inputColor) * GrGLSLExpr4("colorTemp")).c_str()); |
- } else if (GrGradientEffect::kThree_ColorType == ColorTypeFromKey(key)){ |
+ } else if (SkGradientShaderBase::kThree_ColorType == ColorTypeFromKey(key)){ |
builder->fsCodeAppendf("\tfloat oneMinus2t = 1.0 - (2.0 * (%s));\n", |
gradientTValue); |
builder->fsCodeAppendf("\tvec4 colorTemp = clamp(oneMinus2t, 0.0, 1.0) * %s;\n", |
@@ -1006,30 +1023,14 @@ GrGradientEffect::GrGradientEffect(GrContext* ctx, |
fIsOpaque = shader.isOpaque(); |
- SkShader::GradientInfo info; |
- SkScalar pos[3] = {0}; |
- |
- info.fColorCount = 3; |
- info.fColors = &fColors[0]; |
- info.fColorOffsets = &pos[0]; |
- shader.asAGradient(&info); |
+ fColorType = shader.getGradientColorType(&fColors[0]); |
// The two and three color specializations do not currently support tiling. |
- bool foundSpecialCase = false; |
- if (SkShader::kClamp_TileMode == info.fTileMode) { |
- if (2 == info.fColorCount) { |
- fRow = -1; // flag for no atlas |
- fColorType = kTwo_ColorType; |
- foundSpecialCase = true; |
- } else if (3 == info.fColorCount && |
- (SkScalarAbs(pos[1] - SK_ScalarHalf) < SK_Scalar1 / 1000)) { // 3 color symmetric |
- fRow = -1; // flag for no atlas |
- fColorType = kThree_ColorType; |
- foundSpecialCase = true; |
- } |
- } |
- if (foundSpecialCase) { |
- if (SkGradientShader::kInterpolateColorsInPremul_Flag & info.fGradientFlags) { |
+ if (SkGradientShaderBase::kTwo_ColorType == fColorType || |
+ SkGradientShaderBase::kThree_ColorType == fColorType) { |
+ fRow = -1; |
+ |
+ if (SkGradientShader::kInterpolateColorsInPremul_Flag & shader.getGradientFlags()) { |
fPremulType = kBeforeInterp_PremulType; |
} else { |
fPremulType = kAfterInterp_PremulType; |
@@ -1040,7 +1041,6 @@ GrGradientEffect::GrGradientEffect(GrContext* ctx, |
fPremulType = kBeforeInterp_PremulType; |
SkBitmap bitmap; |
shader.getGradientTableBitmap(&bitmap); |
- fColorType = kTexture_ColorType; |
GrTextureStripAtlas::Desc desc; |
desc.fWidth = bitmap.width(); |
@@ -1089,12 +1089,12 @@ bool GrGradientEffect::onIsEqual(const GrEffect& effect) const { |
if (this->fColorType == s.getColorType()){ |
- if (kTwo_ColorType == fColorType) { |
+ if (SkGradientShaderBase::kTwo_ColorType == fColorType) { |
if (*this->getColors(0) != *s.getColors(0) || |
*this->getColors(1) != *s.getColors(1)) { |
return false; |
} |
- } else if (kThree_ColorType == fColorType) { |
+ } else if (SkGradientShaderBase::kThree_ColorType == fColorType) { |
if (*this->getColors(0) != *s.getColors(0) || |
*this->getColors(1) != *s.getColors(1) || |
*this->getColors(2) != *s.getColors(2)) { |