content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java - Issue 2411723002: Split MediaSessionStateChanged() and MediaSessionMetadataChanged()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

Issue 2411723002: Split MediaSessionStateChanged() and MediaSessionMetadataChanged() (Closed)

Patch Set: rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

index 2e9157f818f42ef22fed0d099d03b0ece189a916..f3e2c6a9f860d88c78103ceb205fe86ae57e6c5d 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

@@ -232,11 +232,17 @@ class WebContentsObserverProxy extends WebContentsObserver {

@Override

@CalledByNative

- public void mediaSessionStateChanged(

- boolean isControllable, boolean isSuspended, MediaMetadata metadata) {

+ public void mediaSessionStateChanged(boolean isControllable, boolean isSuspended) {

for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {

- mObserversIterator.next().mediaSessionStateChanged(

- isControllable, isSuspended, metadata);

+ mObserversIterator.next().mediaSessionStateChanged(isControllable, isSuspended);

+ }

+ @Override

+ @CalledByNative

+ public void mediaSessionMetadataChanged(MediaMetadata metadata) {

+ for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {

+ mObserversIterator.next().mediaSessionMetadataChanged(metadata);

}