Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: content/browser/media/session/media_session.cc

Issue 2411723002: Split MediaSessionStateChanged() and MediaSessionMetadataChanged() (Closed)
Patch Set: rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session.cc
diff --git a/content/browser/media/session/media_session.cc b/content/browser/media/session/media_session.cc
index 147b3379af0216820b7ef4bd29844fb71eb3f5bc..aa165b9bf0aad3f374ac31973b7138b5844eb515 100644
--- a/content/browser/media/session/media_session.cc
+++ b/content/browser/media/session/media_session.cc
@@ -75,10 +75,8 @@ void MediaSession::WebContentsDestroyed() {
void MediaSession::SetMetadata(const base::Optional<MediaMetadata>& metadata) {
metadata_ = metadata;
- // TODO(zqzhang): On Android, the metadata is sent though JNI everytime the
- // media session play/pause state changes. Need to find a way to seprate the
- // state change and Metadata update. See https://crbug.com/621855.
- static_cast<WebContentsImpl*>(web_contents())->OnMediaSessionStateChanged();
+ static_cast<WebContentsImpl*>(web_contents())
+ ->OnMediaSessionMetadataChanged();
}
bool MediaSession::AddPlayer(MediaSessionObserver* observer,
« no previous file with comments | « content/browser/android/web_contents_observer_proxy.cc ('k') | content/browser/media/session/media_session_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698