Split MediaSessionStateChanged() and MediaSessionMetadataChanged()

content/browser/android/web_contents_observer_proxy.h

Index: content/browser/android/web_contents_observer_proxy.h
diff --git a/content/browser/android/web_contents_observer_proxy.h b/content/browser/android/web_contents_observer_proxy.h
index f6d546c6c1298eb30a7efe66efe2ae565cbfb19c..0829acca7a48bdcd2861f41b6c83d46f8441bdc2 100644
--- a/content/browser/android/web_contents_observer_proxy.h
+++ b/content/browser/android/web_contents_observer_proxy.h
@@ -72,9 +72,9 @@ class WebContentsObserverProxy : public WebContentsObserver {
   void DidStartNavigationToPendingEntry(
       const GURL& url,
       ReloadType reload_type) override;
-  void MediaSessionStateChanged(
-      bool is_controllable,
-      bool is_suspended,
+  void MediaSessionStateChanged(bool is_controllable,
+                                bool is_suspended) override;
+  void MediaSessionMetadataChanged(
       const base::Optional<MediaMetadata>& metadata) override;

[clamy, 2016/10/12 11:43:50]

Considering that this is an optional parameter, couldn't you already avoid to
send every time?

[Zhiqiang Zhang (Slow), 2016/10/12 12:08:27]

As I said in the other reply, `nullopt` metadata is used for unsetting. So if
the metadata is not null, it needs to be passed through this function. So this
where we want to improve.

[clamy, 2016/10/12 12:25:04]

Acknowledged.

   void SetToBaseURLForDataURLIfNeeded(std::string* url);