Fix parseHTMLInteger

Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with
input std::numeric_limits<int>::min which it can't handle because it relies
on an intermediate integer to store the value. So inline the calculation and
use an unsigned integer for the calculation, casting to int when returning.

BUG=654324
Committed: https://crrev.com/cbfd866cbc7981e453dfd9afae669daa567b5cb2
Cr-Commit-Position: refs/heads/master@{#425055}

[rwlbuis, 2016-10-11 23:09:43]

Description was changed from

==========
654324 WIP

BUG=
==========

to

==========
654324 WIP

BUG=654324
==========

[rwlbuis, 2016-10-11 23:16:09]

Description was changed from

==========
654324 WIP

BUG=654324
==========

to

==========
Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with input
std::numeric_limits<int>::min which it can't handle because it relies on an
intermediate integer to store the value. So inline the calculation and use an
unsigned integer for the calculation, casting to int when returning.

BUG=654324
==========

[rwlbuis, 2016-10-11 23:16:39]

Description was changed from

==========
Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with input
std::numeric_limits<int>::min which it can't handle because it relies on an
intermediate integer to store the value. So inline the calculation and use an
unsigned integer for the calculation, casting to int when returning.

BUG=654324
==========

to

==========
Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with
input std::numeric_limits<int>::min which it can't handle because it relies
on an intermediate integer to store the value. So inline the calculation and
use an unsigned integer for the calculation, casting to int when returning.

BUG=654324
==========

[rwlbuis, 2016-10-11 23:21:20]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-10-11 23:21:20]

PTAL.

I thought about making this work using charactersToUIntStrict, but then
afterwards we have to clamp against integer range (after first clamping to
unsigned range) which is not very efficient,

Also for fixing toIntegralType I think it would either slow down the value
calculation or would need to duplicate the while loop into a positive and
negative sign block.

[tkent, 2016-10-12 00:30:25]

Please add a test.  C++ unit test would be reasonable in this case, I think.

[rwlbuis, 2016-10-12 13:18:00]

On 2016/10/12 00:30:25, tkent wrote:
> Please add a test.  C++ unit test would be reasonable in this case, I think.

Done!

[tkent, 2016-10-12 22:55:29]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-10-12 22:55:29]

lgtm

[commit-bot: I haz the power, 2016-10-12 22:55:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:59:32]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rwlbuis, 2016-10-13 14:12:56]

Patchset #5 (id:80001) has been deleted

[rwlbuis, 2016-10-13 15:34:20]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-10-13 15:34:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2411713002/#ps100001
(title: "Try to fix warning for test")

[commit-bot: I haz the power, 2016-10-13 15:34:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 16:37:44]

Description was changed from

==========
Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with
input std::numeric_limits<int>::min which it can't handle because it relies
on an intermediate integer to store the value. So inline the calculation and
use an unsigned integer for the calculation, casting to int when returning.

BUG=654324
==========

to

==========
Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with
input std::numeric_limits<int>::min which it can't handle because it relies
on an intermediate integer to store the value. So inline the calculation and
use an unsigned integer for the calculation, casting to int when returning.

BUG=654324
==========

[commit-bot: I haz the power, 2016-10-13 16:37:45]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-13 16:40:50]

Description was changed from

==========
Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with
input std::numeric_limits<int>::min which it can't handle because it relies
on an intermediate integer to store the value. So inline the calculation and
use an unsigned integer for the calculation, casting to int when returning.

BUG=654324
==========

to

==========
Fix parseHTMLInteger

In r423595 I made a change that caused toIntegralType to be called with
input std::numeric_limits<int>::min which it can't handle because it relies
on an intermediate integer to store the value. So inline the calculation and
use an unsigned integer for the calculation, casting to int when returning.

BUG=654324

Committed: https://crrev.com/cbfd866cbc7981e453dfd9afae669daa567b5cb2
Cr-Commit-Position: refs/heads/master@{#425055}
==========

[commit-bot: I haz the power, 2016-10-13 16:40:51]

Patchset 5 (id:??) landed as
https://crrev.com/cbfd866cbc7981e453dfd9afae669daa567b5cb2
Cr-Commit-Position: refs/heads/master@{#425055}