Get rid of CFX_ArrayTemplate<CPDF_Object*>

Get rid of CFX_ArrayTemplate<CPDF_Object*>

They won't work with std::unique_ptr down the road, so replace
with std::vector.

Committed: https://pdfium.googlesource.com/pdfium/+/74b8c6ed314cfcc83aea13f028b4231db26e6ff8

[Tom Sepez, 2016-10-11 22:34:43]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 22:34:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 22:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:37:42]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2425)

[Tom Sepez, 2016-10-11 23:10:36]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 23:10:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-11 23:10:54]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-10-11 23:10:55]

Lei, for review.

https://codereview.chromium.org/2411703003/diff/1/core/fpdfapi/edit/cpdf_page...
File core/fpdfapi/edit/cpdf_pagecontentgenerator.h (right):

https://codereview.chromium.org/2411703003/diff/1/core/fpdfapi/edit/cpdf_page...
core/fpdfapi/edit/cpdf_pagecontentgenerator.h:42: std::vector<CPDF_PageObject*>
m_pageObjects;
Note: overzealous search, take this one out anyways while we're at it.

[commit-bot: I haz the power, 2016-10-11 23:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:24:55]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-11 23:30:26]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 23:30:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:45:13]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-11 23:49:51]

lgtm

https://codereview.chromium.org/2411703003/diff/20001/core/fpdfapi/edit/cpdf_...
File core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp (right):

https://codereview.chromium.org/2411703003/diff/20001/core/fpdfapi/edit/cpdf_...
core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp:46: if (pPageObj &&
pPageObj->IsImage())
Don't we already know |pPageObj| won't be nullptr since InsertPageObject() above
is the only place that appends to the vector?

Can this be:

for (CPDF_PageObject* pPageObj : m_pageObjects) {
  auto* pImageObj = pPageObj->AsImage();
  if (pImageObj)
    ProcessImage(buf, pImageObj);
}

[Tom Sepez, 2016-10-12 16:17:38]

https://codereview.chromium.org/2411703003/diff/20001/core/fpdfapi/edit/cpdf_...
File core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp (right):

https://codereview.chromium.org/2411703003/diff/20001/core/fpdfapi/edit/cpdf_...
core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp:46: if (pPageObj &&
pPageObj->IsImage())
On 2016/10/11 23:49:51, Lei Zhang wrote:
> Don't we already know |pPageObj| won't be nullptr since InsertPageObject()
above
> is the only place that appends to the vector?
> 
> Can this be:
> 
> for (CPDF_PageObject* pPageObj : m_pageObjects) {
>   auto* pImageObj = pPageObj->AsImage();
>   if (pImageObj)
>     ProcessImage(buf, pImageObj);
> }

Done.

[Tom Sepez, 2016-10-12 16:18:22]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-10-12 16:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2411703003/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-10-12 16:18:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 16:38:43]

Description was changed from

==========
Get rid of CFX_ArrayTemplate<CPDF_Object*>

They won't work with std::unique_ptr down the road, so replace
with std::vector.
==========

to

==========
Get rid of CFX_ArrayTemplate<CPDF_Object*>

They won't work with std::unique_ptr down the road, so replace
with std::vector.

Committed:
https://pdfium.googlesource.com/pdfium/+/74b8c6ed314cfcc83aea13f028b4231db26e...
==========

[commit-bot: I haz the power, 2016-10-12 16:38:44]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/74b8c6ed314cfcc83aea13f028b4231db26e...