Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: content/browser/zygote_host/zygote_host_impl_linux.cc

Issue 24117002: Print a better error message (links to doc) on SUID sandbox problems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/zygote_host/zygote_host_impl_linux.cc
diff --git a/content/browser/zygote_host/zygote_host_impl_linux.cc b/content/browser/zygote_host/zygote_host_impl_linux.cc
index 3629a841ec1149e2002a8259390f670387768f3b..30da9540404d76a96d507d1a05f5221daa7dac3e 100644
--- a/content/browser/zygote_host/zygote_host_impl_linux.cc
+++ b/content/browser/zygote_host/zygote_host_impl_linux.cc
@@ -127,7 +127,10 @@ void ZygoteHostImpl::Init(const std::string& sandbox_cmd) {
struct stat st;
if (stat(sandbox_binary_.c_str(), &st) != 0) {
LOG(FATAL) << "The SUID sandbox helper binary is missing: "
- << sandbox_binary_ << " Aborting now.";
+ << sandbox_binary_ << " Aborting now. "
+ << "See https://code.google.com/p/chromium/wiki/LinuxSUIDSandbox "
Lei Zhang 2013/09/12 01:07:31 Maybe just add a helper function instead of repeat
+ << "and https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment "
+ << "for more info.";
}
if (access(sandbox_binary_.c_str(), X_OK) == 0 &&
@@ -143,7 +146,10 @@ void ZygoteHostImpl::Init(const std::string& sandbox_cmd) {
LOG(FATAL) << "The SUID sandbox helper binary was found, but is not "
"configured correctly. Rather than run without sandboxing "
"I'm aborting now. You need to make sure that "
- << sandbox_binary_ << " is owned by root and has mode 4755.";
+ << sandbox_binary_ << " is owned by root and has mode 4755. "
+ << "See https://code.google.com/p/chromium/wiki/LinuxSUIDSandbox "
+ << "and https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment "
+ << "for more info.";
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698