chrome/browser/chrome_content_browser_client.cc - Issue 2411693003: Move blocking of top-level navigations to nested URLs with extension origins from non-extension pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2411693003: Move blocking of top-level navigations to nested URLs with extension origins from non-extension pro… (Closed)

Patch Set: review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 007f69b15ec609724447899f31792ce6e18090a8..0dd2ff3d3039568a11579f38b5ad6f407e1b3245 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -3196,8 +3196,7 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(

#endif

#if defined(ENABLE_EXTENSIONS)

- if (!handle->IsInMainFrame())

- throttles.push_back(new extensions::ExtensionNavigationThrottle(handle));

+ throttles.push_back(new extensions::ExtensionNavigationThrottle(handle));

#endif

subresource_filter::ContentSubresourceFilterDriverFactory*