Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2411693003: Move blocking of top-level navigations to nested URLs with extension origins from non-extension pro… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 66b9295e5c75c0d90b7227fceb4984fa9bec802e..e2293fd5eb71ca4b5406a389d4fd8bdf403a31f9 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -76,6 +76,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// associated with this navigation.
static std::unique_ptr<NavigationHandleImpl> Create(
const GURL& url,
+ const GURL& site_url,
FrameTreeNode* frame_tree_node,
bool is_renderer_initiated,
bool is_synchronous,
@@ -87,6 +88,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// NavigationHandle implementation:
const GURL& GetURL() override;
+ const GURL& GetSiteURL() override;
bool IsInMainFrame() override;
bool IsParentMainFrame() override;
bool IsRendererInitiated() override;
@@ -298,6 +300,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
};
NavigationHandleImpl(const GURL& url,
+ const GURL& site_url,
FrameTreeNode* frame_tree_node,
bool is_renderer_initiated,
bool is_synchronous,
@@ -335,6 +338,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// See NavigationHandle for a description of those member variables.
GURL url_;
+ GURL site_url_;
nasko 2016/10/12 17:00:35 Let's store the SiteInstance here instead of the U
jam 2016/10/12 22:10:45 Done.
Referrer sanitized_referrer_;
bool has_user_gesture_;
ui::PageTransition transition_;

Powered by Google App Engine
This is Rietveld 408576698