Move blocking of top-level navigations to nested URLs with extension origins from non-extension pro…

content/public/browser/navigation_handle.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 
 #include <memory>
 
 #include "content/common/content_export.h"
 #include "content/public/browser/navigation_throttle.h"
 #include "content/public/common/referrer.h"
 #include "net/base/net_errors.h"
 #include "ui/base/page_transition_types.h"
 
 class GURL;
 
 namespace net {
 class HttpResponseHeaders;
 }  // namespace net
 
 namespace content {
 class NavigationData;
 class NavigationThrottle;
 class RenderFrameHost;
+class SiteInstance;
 class WebContents;
 
 // A NavigationHandle tracks information related to a single navigation.
 // NavigationHandles are provided to several WebContentsObserver methods to
 // allow observers to track specific navigations. Observers should clear any
 // references to a NavigationHandle at the time of
 // WebContentsObserver::DidFinishNavigation, just before the handle is
 // destroyed.
 class CONTENT_EXPORT NavigationHandle {
  public:
   virtual ~NavigationHandle() {}
 
   // Parameters available at navigation start time -----------------------------
   //
   // These parameters are always available during the navigation. Note that
   // some may change during navigation (e.g. due to server redirects).
 
   // The URL the frame is navigating to. This may change during the navigation
   // when encountering a server redirect.
   // This URL may not be the same as the virtual URL returned from
   // WebContents::GetVisibleURL and WebContents::GetLastCommittedURL. For
   // example, viewing a page's source navigates to the URL of the page, but the
   // virtual URL is prefixed with "view-source:".
   virtual const GURL& GetURL() = 0;
 
+  // Returns the SiteInstance that created the request.

[alexmos, 2016/10/12 23:13:28]

To eliminate any possible confusion with the initiator, would it be worth adding
a concrete example to the comment, along the lines of: If a frame in
SiteInstance A navigates a frame in SiteInstance B to a URL in SiteInstance C,
then this returns B.

[jam, 2016/10/13 00:14:46]

Done.

+  virtual SiteInstance* GetCreatorSiteInstance() = 0;

[alexmos, 2016/10/12 23:13:28]

We had some more discussions about the name, and we think it might be better to
name this GetStartingSiteInstance().  WDYT?

[jam, 2016/10/13 00:14:46]

Done.

+
   // Whether the navigation is taking place in the main frame or in a subframe.
   // This remains constant over the navigation lifetime.
   virtual bool IsInMainFrame() = 0;
 
   // Whether the navigation is taking place in a frame that is a direct child
   // of the main frame. This remains constant over the navigation lifetime.
   virtual bool IsParentMainFrame() = 0;
 
   // Whether the navigation was initated by the renderer process. Examples of
   // renderer-initiated navigations include:
@@ skipping 160 matching lines @@
 
   // The NavigationData that the embedder returned from
   // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
   // be a clone of the NavigationData.
   virtual NavigationData* GetNavigationData() = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_