Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/net/chrome_extensions_network_delegate.cc

Issue 2411693003: Move blocking of top-level navigations to nested URLs with extension origins from non-extension pro… (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/chrome_extensions_network_delegate.h" 5 #include "chrome/browser/net/chrome_extensions_network_delegate.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "net/base/net_errors.h" 10 #include "net/base/net_errors.h"
11 11
12 #if defined(ENABLE_EXTENSIONS) 12 #if defined(ENABLE_EXTENSIONS)
13 #include "chrome/browser/browser_process.h" 13 #include "chrome/browser/browser_process.h"
14 #include "chrome/browser/extensions/api/proxy/proxy_api.h" 14 #include "chrome/browser/extensions/api/proxy/proxy_api.h"
15 #include "chrome/browser/extensions/event_router_forwarder.h" 15 #include "chrome/browser/extensions/event_router_forwarder.h"
16 #include "chrome/browser/profiles/profile_manager.h" 16 #include "chrome/browser/profiles/profile_manager.h"
17 #include "chrome/browser/renderer_host/chrome_navigation_ui_data.h" 17 #include "chrome/browser/renderer_host/chrome_navigation_ui_data.h"
18 #include "content/public/browser/browser_thread.h" 18 #include "content/public/browser/browser_thread.h"
19 #include "content/public/browser/render_frame_host.h" 19 #include "content/public/browser/render_frame_host.h"
20 #include "content/public/browser/resource_request_info.h" 20 #include "content/public/browser/resource_request_info.h"
21 #include "extensions/browser/api/web_request/web_request_api.h" 21 #include "extensions/browser/api/web_request/web_request_api.h"
22 #include "extensions/browser/extension_navigation_ui_data.h" 22 #include "extensions/browser/extension_navigation_ui_data.h"
23 #include "extensions/browser/info_map.h" 23 #include "extensions/browser/info_map.h"
24 #include "extensions/browser/process_manager.h" 24 #include "extensions/browser/process_manager.h"
25 #include "extensions/common/constants.h"
26 #include "extensions/common/permissions/api_permission.h"
27 #include "net/url_request/url_request.h" 25 #include "net/url_request/url_request.h"
28 26
29 using content::BrowserThread; 27 using content::BrowserThread;
30 using content::ResourceRequestInfo; 28 using content::ResourceRequestInfo;
31 using extensions::ExtensionWebRequestEventRouter; 29 using extensions::ExtensionWebRequestEventRouter;
32 30
33 namespace { 31 namespace {
34 32
35 enum RequestStatus { REQUEST_STARTED, REQUEST_DONE }; 33 enum RequestStatus { REQUEST_STARTED, REQUEST_DONE };
36 34
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 170
173 void ChromeExtensionsNetworkDelegateImpl::ForwardDoneRequestStatus( 171 void ChromeExtensionsNetworkDelegateImpl::ForwardDoneRequestStatus(
174 net::URLRequest* request) { 172 net::URLRequest* request) {
175 ForwardRequestStatus(REQUEST_DONE, request, profile_); 173 ForwardRequestStatus(REQUEST_DONE, request, profile_);
176 } 174 }
177 175
178 int ChromeExtensionsNetworkDelegateImpl::OnBeforeURLRequest( 176 int ChromeExtensionsNetworkDelegateImpl::OnBeforeURLRequest(
179 net::URLRequest* request, 177 net::URLRequest* request,
180 const net::CompletionCallback& callback, 178 const net::CompletionCallback& callback,
181 GURL* new_url) { 179 GURL* new_url) {
182 const content::ResourceRequestInfo* info =
183 content::ResourceRequestInfo::ForRequest(request);
184 GURL url(request->url());
185
186 // Block top-level navigations to blob: or filesystem: URLs with extension
187 // origin from non-extension processes. See https://crbug.com/645028.
188 bool is_nested_url = url.SchemeIsFileSystem() || url.SchemeIsBlob();
189 bool is_navigation =
190 info && content::IsResourceTypeFrame(info->GetResourceType());
191 url::Origin origin(url);
192 if (is_nested_url && is_navigation && info->IsMainFrame() &&
193 origin.scheme() == extensions::kExtensionScheme &&
194 !extension_info_map_->process_map().Contains(info->GetChildID())) {
195 // Relax this restriction for apps that use <webview>. See
196 // https://crbug.com/652077.
197 const extensions::Extension* extension =
198 extension_info_map_->extensions().GetByID(origin.host());
199 bool has_webview_permission =
200 extension &&
201 extension->permissions_data()->HasAPIPermission(
202 extensions::APIPermission::kWebView);
203 if (!has_webview_permission)
204 return net::ERR_ABORTED;
205 }
206
207 return ExtensionWebRequestEventRouter::GetInstance()->OnBeforeRequest( 180 return ExtensionWebRequestEventRouter::GetInstance()->OnBeforeRequest(
208 profile_, extension_info_map_.get(), 181 profile_, extension_info_map_.get(),
209 GetExtensionNavigationUIData(request), request, callback, new_url); 182 GetExtensionNavigationUIData(request), request, callback, new_url);
210 } 183 }
211 184
212 int ChromeExtensionsNetworkDelegateImpl::OnBeforeStartTransaction( 185 int ChromeExtensionsNetworkDelegateImpl::OnBeforeStartTransaction(
213 net::URLRequest* request, 186 net::URLRequest* request,
214 const net::CompletionCallback& callback, 187 const net::CompletionCallback& callback,
215 net::HttpRequestHeaders* headers) { 188 net::HttpRequestHeaders* headers) {
216 return ExtensionWebRequestEventRouter::GetInstance()->OnBeforeSendHeaders( 189 return ExtensionWebRequestEventRouter::GetInstance()->OnBeforeSendHeaders(
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 } 365 }
393 366
394 net::NetworkDelegate::AuthRequiredResponse 367 net::NetworkDelegate::AuthRequiredResponse
395 ChromeExtensionsNetworkDelegate::OnAuthRequired( 368 ChromeExtensionsNetworkDelegate::OnAuthRequired(
396 net::URLRequest* request, 369 net::URLRequest* request,
397 const net::AuthChallengeInfo& auth_info, 370 const net::AuthChallengeInfo& auth_info,
398 const AuthCallback& callback, 371 const AuthCallback& callback,
399 net::AuthCredentials* credentials) { 372 net::AuthCredentials* credentials) {
400 return net::NetworkDelegate::AUTH_REQUIRED_RESPONSE_NO_ACTION; 373 return net::NetworkDelegate::AUTH_REQUIRED_RESPONSE_NO_ACTION;
401 } 374 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698