Whitelisting one more crx download url

Whitelisting one more crx download url

BUG=654730
Committed: https://crrev.com/e8a03ecf2576dd11aeb1cb59d7aee6c68d13fd81
Cr-Commit-Position: refs/heads/master@{#424414}

[mamir, 2016-10-11 12:29:48]

Description was changed from

==========
Whitelisting one more crx download url

BUG=
==========

to

==========
Whitelisting one more crx download url

BUG=654730
==========

[mamir, 2016-10-11 12:30:02]

mamir@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2016-10-11 12:43:51]

LGTM with one nit

https://codereview.chromium.org/2411673002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/2411673002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_url_filter.cc:360: for (const
char* kCrxDownloadUrl : kCrxDownloadUrls) {
nit: kCrxDownloadUrl should use regular variable naming now, i.e.
crx_download_url (or crx_download_url_str or something to avoid collision with
the GURL below)

[mamir, 2016-10-11 12:48:53]

https://codereview.chromium.org/2411673002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_url_filter.cc (right):

https://codereview.chromium.org/2411673002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_url_filter.cc:360: for (const
char* kCrxDownloadUrl : kCrxDownloadUrls) {
On 2016/10/11 12:43:50, Marc Treib wrote:
> nit: kCrxDownloadUrl should use regular variable naming now, i.e.
> crx_download_url (or crx_download_url_str or something to avoid collision with
> the GURL below)

Done.

[mamir, 2016-10-11 12:49:10]

The CQ bit was checked by mamir@chromium.org

[mamir, 2016-10-11 12:49:10]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2411673002/#ps20001
(title: "response to code review")

[commit-bot: I haz the power, 2016-10-11 12:49:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 13:32:06]

Description was changed from

==========
Whitelisting one more crx download url

BUG=654730
==========

to

==========
Whitelisting one more crx download url

BUG=654730
==========

[commit-bot: I haz the power, 2016-10-11 13:32:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-11 13:34:11]

Description was changed from

==========
Whitelisting one more crx download url

BUG=654730
==========

to

==========
Whitelisting one more crx download url

BUG=654730

Committed: https://crrev.com/e8a03ecf2576dd11aeb1cb59d7aee6c68d13fd81
Cr-Commit-Position: refs/heads/master@{#424414}
==========

[commit-bot: I haz the power, 2016-10-11 13:34:12]

Patchset 2 (id:??) landed as
https://crrev.com/e8a03ecf2576dd11aeb1cb59d7aee6c68d13fd81
Cr-Commit-Position: refs/heads/master@{#424414}