Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2411643003: Remove deprecated methods PathFromFSRef and FSRefFromPath. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated methods PathFromFSRef and FSRefFromPath. BUG=650790 Committed: https://crrev.com/6ac22593205ba92063cd5ae0201cf2ed2880facb Cr-Commit-Position: refs/heads/master@{#424629}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments from thakis. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M base/mac/mac_util.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M base/mac/mac_util.mm View 1 chunk +0 lines, -13 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M base/process/memory_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/animation/animation_mac.mm View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
erikchen
thakis: Please review.
4 years, 2 months ago (2016-10-11 17:46:50 UTC) #2
Nico
lgtm Nice, grats! https://codereview.chromium.org/2411643003/diff/1/base/mac/mac_util.h File base/mac/mac_util.h (right): https://codereview.chromium.org/2411643003/diff/1/base/mac/mac_util.h#newcode8 base/mac/mac_util.h:8: #include <Carbon/Carbon.h> Do we still need ...
4 years, 2 months ago (2016-10-11 18:25:05 UTC) #3
erikchen
https://codereview.chromium.org/2411643003/diff/1/base/mac/mac_util.h File base/mac/mac_util.h (right): https://codereview.chromium.org/2411643003/diff/1/base/mac/mac_util.h#newcode8 base/mac/mac_util.h:8: #include <Carbon/Carbon.h> On 2016/10/11 18:25:05, Nico wrote: > Do ...
4 years, 2 months ago (2016-10-11 21:02:11 UTC) #4
erikchen
avi: Please review content/
4 years, 2 months ago (2016-10-11 21:02:46 UTC) #6
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-12 00:12:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411643003/20001
4 years, 2 months ago (2016-10-12 00:13:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 01:17:11 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:20:44 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6ac22593205ba92063cd5ae0201cf2ed2880facb
Cr-Commit-Position: refs/heads/master@{#424629}

Powered by Google App Engine
This is Rietveld 408576698