runtime/vm/parser.cc - Issue 2411633002: Add `=` as default-value separator for named parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 2411633002: Add `=` as default-value separator for named parameters. (Closed)

Patch Set: Remove comments, fix spe quotes and indent, mark test failing Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index cb9c620101ec318ff2baffb48bf4f5a698cea49e..78fe0942664f108d8272055a7e463501973d2fca 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -2184,7 +2184,7 @@ void Parser::ParseFormalParameter(bool allow_explicit_default_value,

if (params->has_optional_positional_parameters) {

ExpectToken(Token::kASSIGN);

} else {

- ExpectToken(Token::kCOLON);

+ ConsumeToken();

}

params->num_optional_parameters++;

params->has_explicit_default_values = true; // Also if explicitly NULL.