Add `=` as default-value separator for named parameters.

Add `=` as default-value separator for named parameters.

Fixes issue #27559.

BUG= http://dartbug.com/27559
R=asiva@google.com, eernst@google.com, floitsch@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/efb9a12811b5707410b0e21ad13f498d477d3746

[Lasse Reichstein Nielsen, 2016-10-11 09:33:47]

lrn@google.com changed reviewers:
+ asiva@google.com, brianwilkerson@google.com, eernst@google.com,
floitsch@google.com, sigmund@google.com

[floitsch, 2016-10-11 09:37:11]

LGTM.

https://codereview.chromium.org/2411633002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (left):

https://codereview.chromium.org/2411633002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:2793:
ParserErrorCode.WRONG_SEPARATOR_FOR_NAMED_PARAMETER, separator);
Remove error message.

https://codereview.chromium.org/2411633002/diff/1/pkg/compiler/lib/src/parser...
File pkg/compiler/lib/src/parser/parser.dart (left):

https://codereview.chromium.org/2411633002/diff/1/pkg/compiler/lib/src/parser...
pkg/compiler/lib/src/parser/parser.dart:484: listener.reportError(equal,
MessageKind.NAMED_PARAMETER_WITH_EQUALS);
Remove that error message.

[Lasse Reichstein Nielsen, 2016-10-11 13:35:18]

Have update that removes the error messages. 
Not uploaded yet, also removing some now failing negative tests.

https://codereview.chromium.org/2411633002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (left):

https://codereview.chromium.org/2411633002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:2793:
ParserErrorCode.WRONG_SEPARATOR_FOR_NAMED_PARAMETER, separator);
On 2016/10/11 09:37:11, floitsch wrote:
> Remove error message.

Done.

https://codereview.chromium.org/2411633002/diff/1/pkg/compiler/lib/src/parser...
File pkg/compiler/lib/src/parser/parser.dart (left):

https://codereview.chromium.org/2411633002/diff/1/pkg/compiler/lib/src/parser...
pkg/compiler/lib/src/parser/parser.dart:484: listener.reportError(equal,
MessageKind.NAMED_PARAMETER_WITH_EQUALS);
On 2016/10/11 09:37:11, floitsch wrote:
> Remove that error message.

Done.

[eernst, 2016-10-11 20:59:50]

LGTM, with one style comment about the spec (and one comment about a vm change
making my reasoning explicit, just to double check that it should work).

https://codereview.chromium.org/2411633002/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2411633002/diff/1/docs/language/dartLangSpec....
docs/language/dartLangSpec.tex:748: normalFormalParameter ('=' expression)?
We might as well use `=' (also in line 744), in order to keep the same quoting
style as in other grammar rules.

https://codereview.chromium.org/2411633002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2411633002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2187: ConsumeToken();
It was not obvious to me why this would work, but here's the reason I found: (1)
ConsumeToken() consumes the same token which is tested in line 2178, and (2)
ReportError cannot return. Then we know that the consumed token is '=' or ':',
and that `params->has_optional_named_parameters` is true.

[eernst, 2016-10-11 20:59:51]

LGTM, with one style comment about the spec (and one comment about a vm change
making my reasoning explicit, just to double check that it should work).

[Lasse Reichstein Nielsen, 2016-10-12 06:10:58]

https://codereview.chromium.org/2411633002/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/2411633002/diff/1/docs/language/dartLangSpec....
docs/language/dartLangSpec.tex:748: normalFormalParameter ('=' expression)?
Ack. Let's be consistent, even if the difference is darn nigh unreadable :)

https://codereview.chromium.org/2411633002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2411633002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2187: ConsumeToken();
Correct.
ConsumeToken is used to drop the current token and advance to the next, no
matter what it is. It's only used when we have already tested the current token
somewhere else and know what it is.
The ReportError does unwind the stack to report the error. You could think that
it throws (I actually think it longjumps, but potato-potatoh).

[Lasse Reichstein Nielsen, 2016-10-12 07:37:23]

lrn@google.com changed reviewers:
+ hausner@google.com

[Lasse Reichstein Nielsen, 2016-10-12 07:37:24]

Adding hausner, since this is parser related.

For the VM/dart2js/analyzer parts, you only need to comment if there is
something you want changed.

[siva, 2016-10-12 20:40:28]

hausner is on vacation the change to parser.cc LGTM

[Siggi Cherem (dart-lang), 2016-10-13 17:08:22]

dart2js changes lgtm

[Lasse Reichstein Nielsen, 2016-10-14 09:06:49]

Thanks.

https://codereview.chromium.org/2411633002/diff/20001/pkg/compiler/lib/src/di...
File pkg/compiler/lib/src/diagnostics/messages.dart (right):

https://codereview.chromium.org/2411633002/diff/20001/pkg/compiler/lib/src/di...
pkg/compiler/lib/src/diagnostics/messages.dart:1374:
MessageKind.POSITIONAL_PARAMETER_WITH_EQUALS: const MessageTemplate(
Can't help but noticing that the name of this message-kind seems to be wrong.

[Lasse Reichstein Nielsen, 2016-10-14 09:25:51]

Description was changed from

==========
Add `=` as default-value separator for named parameters.

Fixes issue #27559.

BUG= http://dartbug.com/27559
==========

to

==========
Add `=` as default-value separator for named parameters.

Fixes issue #27559.

BUG= http://dartbug.com/27559
R=asiva@google.com, eernst@google.com, floitsch@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/efb9a12811b5707410b0e21ad13f498d477d3746
==========

[Lasse Reichstein Nielsen, 2016-10-14 09:25:53]

Committed patchset #3 (id:40001) manually as
efb9a12811b5707410b0e21ad13f498d477d3746 (presubmit successful).