Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc

Issue 2411613002: Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc
diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc
index 3e0e1865efec5a1640855dc8a168d8534f17521e..63533377e8dbe181f563d66bee330fa9a9aa55df 100644
--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc
+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc
@@ -143,26 +143,27 @@ TEST(AudioEncoderOpusTest, ToggleDtx) {
EXPECT_TRUE(states.encoder->SetDtx(false));
}
-TEST(AudioEncoderOpusTest, SetBitrate) {
+TEST(AudioEncoderOpusTest,
+ OnReceivedTargetAudioBitrateWithoutAudioNetworkAdaptor) {
auto states = CreateCodec(1);
// Constants are replicated from audio_states.encoderopus.cc.
const int kMinBitrateBps = 500;
const int kMaxBitrateBps = 512000;
// Set a too low bitrate.
- states.encoder->SetTargetBitrate(kMinBitrateBps - 1);
+ states.encoder->OnReceivedTargetAudioBitrate(kMinBitrateBps - 1);
EXPECT_EQ(kMinBitrateBps, states.encoder->GetTargetBitrate());
// Set a too high bitrate.
- states.encoder->SetTargetBitrate(kMaxBitrateBps + 1);
+ states.encoder->OnReceivedTargetAudioBitrate(kMaxBitrateBps + 1);
EXPECT_EQ(kMaxBitrateBps, states.encoder->GetTargetBitrate());
// Set the minimum rate.
- states.encoder->SetTargetBitrate(kMinBitrateBps);
+ states.encoder->OnReceivedTargetAudioBitrate(kMinBitrateBps);
EXPECT_EQ(kMinBitrateBps, states.encoder->GetTargetBitrate());
// Set the maximum rate.
- states.encoder->SetTargetBitrate(kMaxBitrateBps);
+ states.encoder->OnReceivedTargetAudioBitrate(kMaxBitrateBps);
EXPECT_EQ(kMaxBitrateBps, states.encoder->GetTargetBitrate());
// Set rates from 1000 up to 32000 bps.
for (int rate = 1000; rate <= 32000; rate += 1000) {
- states.encoder->SetTargetBitrate(rate);
+ states.encoder->OnReceivedTargetAudioBitrate(rate);
EXPECT_EQ(rate, states.encoder->GetTargetBitrate());
}
}
@@ -187,7 +188,7 @@ void TestSetPacketLossRate(AudioEncoderOpus* encoder,
const std::vector<double>& losses,
double expected_return) {
for (double loss : losses) {
- encoder->SetProjectedPacketLossRate(loss);
+ encoder->OnReceivedUplinkPacketLossFraction(loss);
EXPECT_DOUBLE_EQ(expected_return, encoder->packet_loss_rate());
}
}

Powered by Google App Engine
This is Rietveld 408576698