Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js

Issue 2411533002: [Devtools] Added data to networking timeline canvas experiment (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
index 2bd1c76259bac2184824aa1f1eb9b0782475dcac..3bcf6cbfe66c90bdf6a8145308e3648abc27be9b 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
@@ -24,9 +24,27 @@ WebInspector.NetworkTimelineColumn = function(networkLogView, dataGrid)
this._networkLogView = networkLogView;
/** @type {!Array<!WebInspector.NetworkRequest>} */
this._requestData = [];
+ this.scheduleUpdate();
dgozman 2016/10/11 19:19:41 I don't think we need to schedule until wasShown.
}
WebInspector.NetworkTimelineColumn.prototype = {
+ scheduleRefreshData: function()
+ {
+ this._needsRefreshData = true;
+ },
+
+ _refreshDataIfNeeded: function()
+ {
+ if (!this._needsRefreshData)
+ return;
+ this._needsRefreshData = false;
+ var currentNode = this._dataGrid.rootNode();
+ this._requestData = [];
+ while (currentNode = currentNode.traverseNextNode(true))
+ this._requestData.push(currentNode.request());
+ this._update();
+ },
+
scheduleUpdate: function()
{
if (this._updateRequestID)
@@ -39,6 +57,8 @@ WebInspector.NetworkTimelineColumn.prototype = {
this.element.window().cancelAnimationFrame(this._updateRequestID);
this._updateRequestID = null;
+ this._refreshDataIfNeeded();
+
this._startTime = this._networkLogView.calculator().minimumBoundary();
this._endTime = this._networkLogView.calculator().maximumBoundary();
this._resetCanvas();
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698