Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2411533002: [Devtools] Added data to networking timeline canvas experiment (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index eb1786b63107dcefab4264d1105af70b226fbcc7..9cd55bdeb62b5e9806a625338e585dbb8410acc5 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -293,8 +293,8 @@ WebInspector.NetworkLogView.prototype = {
this._timelineWidget.element.classList.add("network-timeline-view");
this._splitWidget.setMainWidget(this._timelineWidget);
- var networkTimelineView = new WebInspector.NetworkTimelineColumn(this, this._dataGrid);
- networkTimelineView.show(this._timelineWidget.element);
+ this._timelineColumn = new WebInspector.NetworkTimelineColumn(this, this._dataGrid);
+ this._timelineColumn.show(this._timelineWidget.element);
this.switchViewMode(false);
} else {
this._createTable();
@@ -671,6 +671,8 @@ WebInspector.NetworkLogView.prototype = {
this._staleRequestIds = {};
this._updateSummaryBar();
+ if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
+ this._timelineColumn.refreshData();
},
reset: function()
@@ -1125,13 +1127,15 @@ WebInspector.NetworkLogView.prototype = {
return;
this._timelineColumnSortIcon.classList.remove("sort-ascending", "sort-descending");
- if (this._dataGrid.sortColumnIdentifier() !== "timeline")
- return;
- if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascending)
- this._timelineColumnSortIcon.classList.add("sort-ascending");
- else
- this._timelineColumnSortIcon.classList.add("sort-descending");
+ if (this._dataGrid.sortColumnIdentifier() === "timeline") {
+ if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascending)
+ this._timelineColumnSortIcon.classList.add("sort-ascending");
+ else
+ this._timelineColumnSortIcon.classList.add("sort-descending");
+ }
+
+ this._timelineColumn.refreshData();
},
/**

Powered by Google App Engine
This is Rietveld 408576698