Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2411533002: [Devtools] Added data to networking timeline canvas experiment (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index eb1786b63107dcefab4264d1105af70b226fbcc7..5238d628789edd546965d9538cd23a3b0163da97 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -110,7 +110,9 @@ WebInspector.NetworkLogView.Events = {
RequestSelected: Symbol("RequestSelected"),
SearchCountUpdated: Symbol("SearchCountUpdated"),
SearchIndexUpdated: Symbol("SearchIndexUpdated"),
- UpdateRequest: Symbol("UpdateRequest")
+ UpdateRequest: Symbol("UpdateRequest"),
+ RequestsSorted: Symbol("RequestsSorted"),
dgozman 2016/10/10 23:30:18 I feel like this should be direct calls instead of
+ DataRefreshed: Symbol("DataRefreshed")
}
/** @enum {string} */
@@ -671,6 +673,8 @@ WebInspector.NetworkLogView.prototype = {
this._staleRequestIds = {};
this._updateSummaryBar();
+
+ this.dispatchEventToListeners(WebInspector.NetworkLogView.Events.DataRefreshed);
},
reset: function()
@@ -1125,13 +1129,15 @@ WebInspector.NetworkLogView.prototype = {
return;
this._timelineColumnSortIcon.classList.remove("sort-ascending", "sort-descending");
- if (this._dataGrid.sortColumnIdentifier() !== "timeline")
- return;
- if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascending)
- this._timelineColumnSortIcon.classList.add("sort-ascending");
- else
- this._timelineColumnSortIcon.classList.add("sort-descending");
+ if (this._dataGrid.sortColumnIdentifier() === "timeline") {
+ if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascending)
+ this._timelineColumnSortIcon.classList.add("sort-ascending");
+ else
+ this._timelineColumnSortIcon.classList.add("sort-descending");
+ }
+
+ this.dispatchEventToListeners(WebInspector.NetworkLogView.Events.RequestsSorted);
},
/**
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698