[Devtools] Added data to networking timeline canvas experiment

[Devtools] Added data to networking timeline canvas experiment

Added real data to the canvas timeline experiment for network timeline.

http://imgur.com/a/Ky1Q5

R=lushnikov,dgozman
BUG=653738
Committed: https://crrev.com/69ab590632793f5cb4411c8cf791fa72b3e4f93a
Cr-Commit-Position: refs/heads/master@{#424567}

[allada, 2016-10-10 23:11:21]

Description was changed from

==========
[Devtools] Added data to networking timeline canvas experiment

Added real data to the canvas timeline experiment for network timeline.

R=lushnikov,dgozman
BUG=653738
==========

to

==========
[Devtools] Added data to networking timeline canvas experiment

Added real data to the canvas timeline experiment for network timeline.

http://imgur.com/a/Ky1Q5

R=lushnikov,dgozman
BUG=653738
==========

[allada, 2016-10-10 23:13:49]

PTL

[dgozman, 2016-10-10 23:30:18]

https://codereview.chromium.org/2411533002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2411533002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:114:
RequestsSorted: Symbol("RequestsSorted"),
I feel like this should be direct calls instead of events, since NetworkLogView
controls timeline, not vice versa.

[allada, 2016-10-10 23:50:03]

PTaL

[allada, 2016-10-11 00:09:07]

Patchset #2 (id:20001) has been deleted

[allada, 2016-10-11 00:14:37]

Patchset #2 (id:40001) has been deleted

[allada, 2016-10-11 00:14:57]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 00:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 01:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 01:33:04]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-11 02:13:00]

https://codereview.chromium.org/2411533002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2411533002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:31:
refreshData: function()
Now I feel like passing DataGridNode to this function or even an array of
requests, and eliminate this._dataGrid entirely. WDYT?

[allada, 2016-10-11 19:02:05]

PTaL

[allada, 2016-10-11 19:02:10]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 19:02:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-10-11 19:19:41]

lgtm, let's follow up with isShowing logic or something

https://codereview.chromium.org/2411533002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2411533002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:27:
this.scheduleUpdate();
I don't think we need to schedule until wasShown.

https://codereview.chromium.org/2411533002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:55:
_update: function()
We should also not do any updates while !isShowing().

[allada, 2016-10-11 20:53:59]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-11 20:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2411533002/#ps100001
(title: "changes")

[commit-bot: I haz the power, 2016-10-11 20:54:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 22:14:53]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-10-11 22:18:03]

Description was changed from

==========
[Devtools] Added data to networking timeline canvas experiment

Added real data to the canvas timeline experiment for network timeline.

http://imgur.com/a/Ky1Q5

R=lushnikov,dgozman
BUG=653738
==========

to

==========
[Devtools] Added data to networking timeline canvas experiment

Added real data to the canvas timeline experiment for network timeline.

http://imgur.com/a/Ky1Q5

R=lushnikov,dgozman
BUG=653738

Committed: https://crrev.com/69ab590632793f5cb4411c8cf791fa72b3e4f93a
Cr-Commit-Position: refs/heads/master@{#424567}
==========

[commit-bot: I haz the power, 2016-10-11 22:18:04]

Patchset 4 (id:??) landed as
https://crrev.com/69ab590632793f5cb4411c8cf791fa72b3e4f93a
Cr-Commit-Position: refs/heads/master@{#424567}