Enable win32k lockdown for ppapi processes.

Enable win32k lockdown for PPAPI processes.

Remove experiment. Change --disable-win32k-renderer-lockdown to
--disable-win32-lockdown which disables win32k lockdown for all child
processes. Remove unneeded histogram.

BUG=579223
Committed: https://crrev.com/38647c2aa7b1c45430bf7ac7c4023c6e59ecd7bf
Cr-Commit-Position: refs/heads/master@{#424502}

[Will Harris, 2016-10-10 22:00:35]

The CQ bit was checked by wfh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 22:00:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2016-10-10 22:32:10]

Description was changed from

==========
Enable win32k lockdown for ppapi processes.

Remove experiment.

BUG=579223
==========

to

==========
Enable win32k lockdown for PPAPI processes.

Remove experiment. Change --disable-win32k-renderer-lockdown to
--disable-win32-lockdown which disables win32k lockdown for all child
processes. Remove unneeded histogram.

BUG=579223
==========

[Will Harris, 2016-10-10 22:32:28]

wfh@chromium.org changed reviewers:
+ asvitkine@chromium.org, jam@chromium.org

[Will Harris, 2016-10-10 23:04:01]

PTAL

asvitkine -> tools/metrics/histograms.xml
jam -> everything else.

[jam, 2016-10-11 15:44:25]

lgtm

[Alexei Svitkine (slow), 2016-10-11 16:32:10]

lgtm % comments

https://codereview.chromium.org/2411483002/diff/20001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (left):

https://codereview.chromium.org/2411483002/diff/20001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2899: if
(variations::GetVariationParams("EnableWin32kLockDownMimeTypes",
Can you check if some includes can be removed from this file now that this is
deleted?

https://codereview.chromium.org/2411483002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2411483002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:88581: -  <int value="-378033324"
label="disable-win32k-renderer-lockdown"/>
Don't remove existing entries since they're still used to decode data from older
versions.

[Will Harris, 2016-10-11 17:17:26]

Thanks for reviews.

https://codereview.chromium.org/2411483002/diff/20001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (left):

https://codereview.chromium.org/2411483002/diff/20001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2899: if
(variations::GetVariationParams("EnableWin32kLockDownMimeTypes",
On 2016/10/11 16:32:10, Alexei Svitkine (slow) wrote:
> Can you check if some includes can be removed from this file now that this is
> deleted?

variations::GetVariationParams is still used for blink settings field trials so
have to leave it in.

https://codereview.chromium.org/2411483002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2411483002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:88581: -  <int value="-378033324"
label="disable-win32k-renderer-lockdown"/>
On 2016/10/11 16:32:10, Alexei Svitkine (slow) wrote:
> Don't remove existing entries since they're still used to decode data from
older
> versions.

Done. enable-win32k-renderer-lockdown went a long time ago (over a year ago) so
I removed that.

[Will Harris, 2016-10-11 17:17:46]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-10-11 17:17:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2411483002/#ps40001
(title: "readd")

[commit-bot: I haz the power, 2016-10-11 17:18:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-10-11 17:35:44]

Please still keep even the very old one. Otherwise, the dashboard will show
the hashes for those values instead of the strings, which confuses things.

On Tue, Oct 11, 2016 at 1:18 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> CQ is trying da patch. Follow status at
>
> https://chromium-cq-status.appspot.com/v2/patch-status/
> codereview.chromium.org/2411483002/40001
>
>
> https://codereview.chromium.org/2411483002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Will Harris, 2016-10-11 17:38:12]

The CQ bit was unchecked by wfh@chromium.org

[Will Harris, 2016-10-11 17:42:15]

On 2016/10/11 17:35:44, Alexei Svitkine (slow) wrote:
> Please still keep even the very old one. Otherwise, the dashboard will show
> the hashes for those values instead of the strings, which confuses things.

re-added this, sorry about that.

QQ - The switch was removed in 44.0.2401.0 crrev.com/945de9d - which dashboard
would still be showing data from this old a version of Chrome? At what point can
these ever be removed from the histograms.xml? (never is a perfectly reasonable
answer).

[Will Harris, 2016-10-11 17:42:23]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-10-11 17:42:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2411483002/#ps60001
(title: "readd entry")

[commit-bot: I haz the power, 2016-10-11 17:42:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-10-11 18:01:51]

At some point, yes - but we don't have good guidance on that currently.
Something we do want to change - but not yet.

On Tue, Oct 11, 2016 at 1:42 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> CQ is trying da patch. Follow status at
>
> https://chromium-cq-status.appspot.com/v2/patch-status/
> codereview.chromium.org/2411483002/60001
>
>
> https://codereview.chromium.org/2411483002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-10-11 19:05:34]

Description was changed from

==========
Enable win32k lockdown for PPAPI processes.

Remove experiment. Change --disable-win32k-renderer-lockdown to
--disable-win32-lockdown which disables win32k lockdown for all child
processes. Remove unneeded histogram.

BUG=579223
==========

to

==========
Enable win32k lockdown for PPAPI processes.

Remove experiment. Change --disable-win32k-renderer-lockdown to
--disable-win32-lockdown which disables win32k lockdown for all child
processes. Remove unneeded histogram.

BUG=579223
==========

[commit-bot: I haz the power, 2016-10-11 19:05:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-11 19:10:40]

Description was changed from

==========
Enable win32k lockdown for PPAPI processes.

Remove experiment. Change --disable-win32k-renderer-lockdown to
--disable-win32-lockdown which disables win32k lockdown for all child
processes. Remove unneeded histogram.

BUG=579223
==========

to

==========
Enable win32k lockdown for PPAPI processes.

Remove experiment. Change --disable-win32k-renderer-lockdown to
--disable-win32-lockdown which disables win32k lockdown for all child
processes. Remove unneeded histogram.

BUG=579223

Committed: https://crrev.com/38647c2aa7b1c45430bf7ac7c4023c6e59ecd7bf
Cr-Commit-Position: refs/heads/master@{#424502}
==========

[commit-bot: I haz the power, 2016-10-11 19:10:42]

Patchset 4 (id:??) landed as
https://crrev.com/38647c2aa7b1c45430bf7ac7c4023c6e59ecd7bf
Cr-Commit-Position: refs/heads/master@{#424502}