Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2411463002: Suppress 55 spv2 test failures from lack of popup support (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, trchen
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress 55 spv2 test failures from lack of popup support [1] recently added input-select-after-resize.html which crashes with spv2. I found 54 other crashes with the same root cause and have triaged them in FlagExpectations/enable-slimming-paint-v2. These failures can be reproduced with: run-webkit-tests --additional-driver-flag=--enable-slimming-paint-v2 [1] https://chromium.googlesource.com/chromium/src/+/6b08cd23a5bbe4e1d95bb7e0431fc743e6b0180c BUG=654554 Committed: https://crrev.com/4019a49c392955aebccee5de6444551de71760a7 Cr-Commit-Position: refs/heads/master@{#424317}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -54 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 5 chunks +56 lines, -54 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
pdr.
4 years, 2 months ago (2016-10-10 21:42:34 UTC) #2
chrishtr
https://codereview.chromium.org/2411463002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 (left): https://codereview.chromium.org/2411463002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2#oldcode327 third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:327: Bug(none) compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html [ Crash ] Add issue 654554 to ...
4 years, 2 months ago (2016-10-10 23:54:57 UTC) #5
pdr.
On 2016/10/10 at 23:54:57, chrishtr wrote: > https://codereview.chromium.org/2411463002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 > File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 (left): > > https://codereview.chromium.org/2411463002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2#oldcode327 ...
4 years, 2 months ago (2016-10-11 00:10:16 UTC) #6
chrishtr
lgtm Oops sorry.
4 years, 2 months ago (2016-10-11 00:14:57 UTC) #7
pdr.
On 2016/10/11 at 00:14:57, chrishtr wrote: > lgtm > > Oops sorry. No problemo. In ...
4 years, 2 months ago (2016-10-11 00:16:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411463002/1
4 years, 2 months ago (2016-10-11 00:55:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 01:03:17 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 01:04:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4019a49c392955aebccee5de6444551de71760a7
Cr-Commit-Position: refs/heads/master@{#424317}

Powered by Google App Engine
This is Rietveld 408576698