Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2411423004: Disable MemoryPressureListener when memory coordinator is enabled (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 2 months ago
Reviewers:
haraken, chrisha, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, hajimehoshi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable MemoryPressureListener when memory coordinator is enabled Memory coordinator is a replacement of MemoryPressureListener and MemoryPressureMonitor. They shouldn't be enabled at a same time because some components use both MemoryCoordinatorClient and MemoryPressureListener to handle memory pressure. BUG=617492 Committed: https://crrev.com/58dd2fac8722507277dad2615a0691e9dd77077d Cr-Commit-Position: refs/heads/master@{#425602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M content/browser/browser_main_loop.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +24 lines, -13 lines 0 comments Download
M content/browser/devtools/protocol/memory_handler.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
bashi
PTAL
4 years, 2 months ago (2016-10-14 02:59:42 UTC) #4
bashi
piman@: could you review an owner of content/ ?
4 years, 2 months ago (2016-10-14 03:01:26 UTC) #6
haraken
non-owner LGTM
4 years, 2 months ago (2016-10-14 04:06:05 UTC) #9
piman
lgtm
4 years, 2 months ago (2016-10-14 17:54:06 UTC) #10
chrisha
lgtm (We should open up a conversation with the memory-infra folks about how MC should ...
4 years, 2 months ago (2016-10-14 18:16:29 UTC) #11
bashi
On 2016/10/14 18:16:29, chrisha (slow) wrote: > lgtm > > (We should open up a ...
4 years, 2 months ago (2016-10-16 23:16:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411423004/1
4 years, 2 months ago (2016-10-16 23:17:04 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 00:01:30 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 00:03:19 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58dd2fac8722507277dad2615a0691e9dd77077d
Cr-Commit-Position: refs/heads/master@{#425602}

Powered by Google App Engine
This is Rietveld 408576698