Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 24114002: Revert 222470 "Use an X event loop in the GPU process on Linux." This is to (Closed)

Created:
7 years, 3 months ago by Noam Samuel
Modified:
7 years, 3 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 222470 "Use an X event loop in the GPU process on Linux." This is to check if it adds an unexpected dependency on libxi6. > Use an X event loop in the GPU process on Linux. > > In future patches, X windows will be created in the GPU > process, and events sent to these windows will need to > be forwarded to their parent windows. > > Linux uses GTK as the default UI event loop type, but > GTK is not in the GPU process, so the X11 event loop > type is used instead. > > BUG=145600 > > Review URL: https://chromiumcodereview.appspot.com/23477050 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -36 lines) Patch
trunk/src/base/message_loop/message_loop.h View 5 chunks +1 line, -19 lines 0 comments Download
trunk/src/base/message_loop/message_loop.cc View 1 chunk +0 lines, -4 lines 0 comments Download
trunk/src/base/message_loop/message_pump_x11.h View 1 chunk +3 lines, -1 line 0 comments Download
trunk/src/base/message_loop/message_pump_x11.cc View 1 chunk +1 line, -7 lines 0 comments Download
trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
trunk/src/content/gpu/gpu_main.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Noam Samuel
7 years, 3 months ago (2013-09-11 17:52:36 UTC) #1
Noam Samuel
7 years, 3 months ago (2013-09-11 17:52:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r222589.

Powered by Google App Engine
This is Rietveld 408576698