chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc - Issue 2411383003: md-settings: add reset request origin to reset feedback proto.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc

Issue 2411383003: md-settings: add reset request origin to reset feedback proto. (Closed)

Patch Set: Addressed dbeam@'s comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/reset_settings_handler.cc ('k') | chrome/test/data/webui/settings/reset_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc b/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc

index 12003b627406e00df1d4630b5f46b53de6f69bea..7c8f38e8be736dfa5c4df205f36a0f8266953f6c 100644

--- a/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc

+++ b/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc

@@ -92,6 +92,7 @@ TEST_F(ResetSettingsHandlerTest, HandleResetProfileSettings) {

std::string expected_callback_id("dummyCallbackId");

list.AppendString(expected_callback_id);

list.AppendBoolean(false);

+ list.AppendString("");

handler()->HandleResetProfileSettings(&list);

// Check that the delegate ProfileResetter was called.

EXPECT_EQ(1u, handler()->resets());

« no previous file with comments | « chrome/browser/ui/webui/settings/reset_settings_handler.cc ('k') | chrome/test/data/webui/settings/reset_page_test.js » ('j') | no next file with comments »