Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2411373002: [Opus] Set correct -mfpu flag for both NEON and VFP (Closed)

Created:
4 years, 2 months ago by flim-chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Opus] Set correct -mfpu flag for both NEON and VFP BUG=b/32095855 Committed: https://crrev.com/6a7e969402e3e9f4a18ee4a11a5c5af2867b00ab Cr-Commit-Position: refs/heads/master@{#424978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/opus/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
flim-chromium
This fixes the build for both NEON and non-NEON platforms. Could you PTAL? Thanks.
4 years, 2 months ago (2016-10-12 16:44:42 UTC) #4
wzhong
lgtm
4 years, 2 months ago (2016-10-12 18:01:56 UTC) #8
wzhong
lgtm Ping. Our release is pending this fix. Thanks!
4 years, 2 months ago (2016-10-12 23:06:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411373002/1
4 years, 2 months ago (2016-10-12 23:09:03 UTC) #14
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-12 23:09:04 UTC) #16
henrika (OOO until Aug 14)
lgtm
4 years, 2 months ago (2016-10-13 07:49:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411373002/1
4 years, 2 months ago (2016-10-13 07:49:33 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 07:54:03 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 07:55:39 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a7e969402e3e9f4a18ee4a11a5c5af2867b00ab
Cr-Commit-Position: refs/heads/master@{#424978}

Powered by Google App Engine
This is Rietveld 408576698