Add timer to OffscreenCanvas's commit API

Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/0abcd1a8bfe2150793440000ee9c8c077479a734
Cr-Commit-Position: refs/heads/master@{#425242}

[xidachen, 2016-10-12 16:02:01]

Description was changed from

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
==========

to

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-10-12 16:54:48]

xidachen@chromium.org changed reviewers:
+ isherman@chromium.org, junov@chromium.org, xlai@chromium.org, zmo@chromium.org

[xidachen, 2016-10-12 16:54:49]

PTAL

[Justin Novosad, 2016-10-12 21:11:12]

https://codereview.chromium.org/2411363002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2411363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:245:
if (commitType == CommitGPUCanvasGPUCompositing) {
Nit: Should use switch/case IMHO

https://codereview.chromium.org/2411363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:249:
0, 10000000, 50));
I think we should double the number of categories to track calls made on the
main thread separately from those made in workers.  Ther might not be much
difference between the two today, but there could be when we address
crbug.com/655278

https://codereview.chromium.org/2411363002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2411363002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3962: +  <summary>Time spent on
OffscreenCanvas's commit before compositing.</summary>
This is Unclear IMHO. I believe a more accurate description would be: Wall clock
durations of OffscreenCanvas.commit() calls

[Ilya Sherman, 2016-10-12 22:19:09]

Metrics LGTM % a nit:

https://codereview.chromium.org/2411363002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2411363002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3959: +<histogram
name="Blink.Canvas.OffscreenCommit" units="microseconds">
nit: I'd suggest appending "Time" to the end of this metric name, for clarity.

[xidachen, 2016-10-13 01:39:24]

PTAL

isherman@: could you please take another look at histogram changes as we have
added more categories.

https://codereview.chromium.org/2411363002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2411363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:245:
if (commitType == CommitGPUCanvasGPUCompositing) {
On 2016/10/12 21:11:12, Justin Novosad wrote:
> Nit: Should use switch/case IMHO

Done.

https://codereview.chromium.org/2411363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:249:
0, 10000000, 50));
On 2016/10/12 21:11:12, Justin Novosad wrote:
> I think we should double the number of categories to track calls made on the
> main thread separately from those made in workers.  Ther might not be much
> difference between the two today, but there could be when we address
> crbug.com/655278

Done.

https://codereview.chromium.org/2411363002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2411363002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3959: +<histogram
name="Blink.Canvas.OffscreenCommit" units="microseconds">
On 2016/10/12 22:19:09, Ilya Sherman wrote:
> nit: I'd suggest appending "Time" to the end of this metric name, for clarity.

Done.

https://codereview.chromium.org/2411363002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3962: +  <summary>Time spent on
OffscreenCanvas's commit before compositing.</summary>
On 2016/10/12 21:11:12, Justin Novosad wrote:
> This is Unclear IMHO. I believe a more accurate description would be: Wall
clock
> durations of OffscreenCanvas.commit() calls

Done.

[Justin Novosad, 2016-10-13 03:57:44]

lgtm

[Ilya Sherman, 2016-10-13 21:55:02]

metrics still lgtm, thanks

[xidachen, 2016-10-14 01:12:08]

Description was changed from

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-10-14 01:12:08]

xidachen@chromium.org changed reviewers:
- zmo@chromium.org

[xidachen, 2016-10-14 01:13:25]

Description was changed from

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-10-14 01:13:31]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 01:14:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 02:31:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 02:31:48]

Dry run: This issue passed the CQ dry run.

[xidachen, 2016-10-14 02:50:26]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-10-14 02:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 02:56:38]

Description was changed from

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-14 02:56:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-14 02:57:57]

Description was changed from

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add timer to OffscreenCanvas's commit API

This CL adds timer to the OffscreenCanvas's commit API, which tracks the
time spends on commit before compositing. We track this for different
code paths (total of 4).

BUG=653599
TBR=kbr@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/0abcd1a8bfe2150793440000ee9c8c077479a734
Cr-Commit-Position: refs/heads/master@{#425242}
==========

[commit-bot: I haz the power, 2016-10-14 02:57:58]

Patchset 4 (id:??) landed as
https://crrev.com/0abcd1a8bfe2150793440000ee9c8c077479a734
Cr-Commit-Position: refs/heads/master@{#425242}