third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2411333007: [css-grid] Avoid storing pointers to orthogonal grid items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2411333007: [css-grid] Avoid storing pointers to orthogonal grid items (Closed)

Patch Set: Patch for landing. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index b3468a9d7e01e04857a2a91181eeddca0fa95f48..49039a4ae0b27276a8634d5a5c4fbdf6c55ca2c1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -348,7 +348,7 @@ class LayoutGrid final : public LayoutBlock {

size_t m_autoRepeatColumns{0};

size_t m_autoRepeatRows{0};

- Vector<LayoutBox*> m_orthogonalChildren;

+ bool m_hasAnyOrthogonalChildren;

std::unique_ptr<OrderedTrackIndexSet> m_autoRepeatEmptyColumns{nullptr};

std::unique_ptr<OrderedTrackIndexSet> m_autoRepeatEmptyRows{nullptr};