Make HasAutocompleteAttributeValue handle multi-valued strings

components/autofill/core/common/autofill_util_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/autofill_util.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 81 matching lines @@
                  << ", case_sensitive = " << kTestCases[i].case_sensitive);
 
     EXPECT_EQ(kTestCases[i].expected_start,
               GetTextSelectionStart(
                   base::ASCIIToUTF16(kTestCases[i].field_suggestion),
                   base::ASCIIToUTF16(kTestCases[i].field_contents),
                   kTestCases[i].case_sensitive));
   }
 }
 
+// Tests for LowercaseAndTokenizeAttributeString
+TEST(AutofillUtilTest, LowercaseAndTokenizeAttributeString) {
+  const std::vector<std::string> empty_vector;

[vabr (Chromium), 2016/10/13 12:49:31]

nit: Constants have a different naming scheme. Here it would be: kEmptyVector.

Even better, just inlining the constructor call should be easy to read and less
verbose:
std::vector<std::string>()

[jdoerrie, 2016/10/13 13:45:07]

Done.

+
+  const struct {
+    const char* const attribute;
+    std::vector<std::string> tokens;
+  } kTestCases[] = {
+      // Test leading and trailing whitespace, test tabs and newlines
+      {"foo bar baz", {"foo", "bar", "baz"}},
+      {" foo bar baz ", {"foo", "bar", "baz"}},
+      {"foo\tbar baz ", {"foo", "bar", "baz"}},
+      {"foo\nbar baz ", {"foo", "bar", "baz"}},
+
+      // Test different forms of capitalization
+      {"FOO BAR BAZ", {"foo", "bar", "baz"}},
+      {"foO baR bAz", {"foo", "bar", "baz"}},
+
+      // Test collapsing of multiple whitespace characters in a row
+      {"  \t\t\n\n   ", empty_vector},
+      {"foO    baR bAz", {"foo", "bar", "baz"}},
+  };
+
+  for (size_t i = 0; i < arraysize(kTestCases); ++i) {
+    SCOPED_TRACE(testing::Message() << "attribute = "
+                                    << kTestCases[i].attribute);
+
+    EXPECT_EQ(LowercaseAndTokenizeAttributeString(kTestCases[i].attribute),

[vabr (Chromium), 2016/10/13 12:49:31]

nit: Please reverse the order of the arguments of EXPECT_EQ. While all
equivalence relations are symmetric, the effects of the EXPECT_EQ are not: On
failure, the macro will output the first value as "expected" and the second one
as "actual". Therefore we try to match that to avoid confusing error logs.

[jdoerrie, 2016/10/13 13:45:07]

Done.

+              kTestCases[i].tokens);
+  }
+}
 }  // namespace autofill