components/autofill/core/common/autofill_util.h - Issue 2411333004: Make HasAutocompleteAttributeValue handle multi-valued strings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/common/autofill_util.h

Issue 2411333004: Make HasAutocompleteAttributeValue handle multi-valued strings (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill/core/browser/form_structure.cc ('K') | « components/autofill/core/browser/form_structure.cc ('k') | components/autofill/core/common/autofill_util.cc » ('j') | components/autofill/core/common/autofill_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_	5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_

6 #define COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_	6 #define COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_

7	7

8 #include <stddef.h>	8 #include <stddef.h>

9	9

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 bool IsDesktopPlatform();	44 bool IsDesktopPlatform();

45	45

46 bool ShouldSkipField(const FormFieldData& field);	46 bool ShouldSkipField(const FormFieldData& field);

47	47

48 bool IsCheckable(const FormFieldData::CheckStatus& check_status);	48 bool IsCheckable(const FormFieldData::CheckStatus& check_status);

49 bool IsChecked(const FormFieldData::CheckStatus& check_status);	49 bool IsChecked(const FormFieldData::CheckStatus& check_status);

50 void SetCheckStatus(FormFieldData* form_field_data,	50 void SetCheckStatus(FormFieldData* form_field_data,

51 bool isCheckable,	51 bool isCheckable,

52 bool isChecked);	52 bool isChecked);

53	53

	54 // Lowercases and tokenizes a given attribute string.
	vabr (Chromium) 2016/10/13 12:49:31 nit: Here a comment is desired, but perhaps it cou nit: Here a comment is desired, but perhaps it could say things not covered by the function name, in particular what is considered a separator and that empty tokens are ignored. jdoerrie 2016/10/13 13:45:07 Done. Show quoted text On 2016/10/13 12:49:31, vabr (Chromium) wrote: > nit: Here a comment is desired, but perhaps it could say things not covered by > the function name, in particular what is considered a separator and that empty > tokens are ignored. Done.
	55 std::vector<std::string> LowercaseAndTokenizeAttributeString(
	vabr (Chromium) 2016/10/13 12:49:31 Please #include <string> and #include <vector>. O Please #include <string> and #include <vector>. Once you do that, you can remove #include <vector> from the .cc file. jdoerrie 2016/10/13 13:45:07 Done. Show quoted text On 2016/10/13 12:49:31, vabr (Chromium) wrote: > Please > #include <string> > and > #include <vector>. > > Once you do that, you can remove #include <vector> from the .cc file. Done.
	56 const std::string& attribute);

	57

54 } // namespace autofill	58 } // namespace autofill

55	59

56 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_	60 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_UTIL_H_

OLD	NEW