Make HasAutocompleteAttributeValue handle multi-valued strings

components/autofill/content/renderer/password_form_conversion_utils.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_form_conversion_utils.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
 
 #include "base/i18n/case_conversion.h"
 #include "base/lazy_instance.h"
 #include "base/macros.h"
 #include "base/metrics/histogram_macros.h"
+#include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
+#include "components/autofill/core/common/autofill_util.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_field_prediction_map.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFormControlElement.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/re2/src/re2/re2.h"
@@ skipping 666 matching lines @@
     return std::unique_ptr<PasswordForm>();
 
   // No actual action on the form, so use the the origin as the action.
   password_form->action = password_form->origin;
 
   return password_form;
 }
 
 bool HasAutocompleteAttributeValue(const blink::WebInputElement& element,
                                    const char* value_in_lowercase) {
-  return base::LowerCaseEqualsASCII(
-      base::StringPiece16(element.getAttribute("autocomplete")),
-      value_in_lowercase);
+  base::string16 autocomplete_attribute(element.getAttribute("autocomplete"));

[vabr (Chromium), 2016/10/13 12:49:31]

Please
#include "base/strings/string16.h"

[jdoerrie, 2016/10/13 13:45:07]

Done.

+  // Lowercase and tokenize attribute string. Convert to UTF8 beforehand.

[vabr (Chromium), 2016/10/13 12:49:31]

Your comments here and on line 712 are correct and well written, but perhaps not
necessary. The style guide [1] suggests writing comments for "tricky,
non-obvious, interesting, or important parts of your code". Here, the code is
short and the method names are descriptive, so perhaps even without comments,
their purpose is clear.

[1] https://google.github.io/styleguide/cppguide.html#Implementation_Comments

[jdoerrie, 2016/10/13 13:45:07]

Done.

+  std::vector<std::string> tokens = LowercaseAndTokenizeAttributeString(
+      base::UTF16ToUTF8(autocomplete_attribute));
+
+  // Return if any of the obtained attribute tokens equals the value.

[vabr (Chromium), 2016/10/13 12:49:31]

optional nit: if -> whether

[jdoerrie, 2016/10/13 13:45:07]

Acknowledged.

+  return base::ContainsValue(tokens, value_in_lowercase);
 }
 
 }  // namespace autofill