arc: Empty implementation of ARC content file system

arc: Empty implementation of ARC content file system

Actual implementation will be added later.

BUG=654684
Committed: https://crrev.com/f506bdfec37f2e79353169d874b1eb8fbf155873
Cr-Commit-Position: refs/heads/master@{#425034}

[hashimoto, 2016-10-12 09:49:56]

hashimoto@chromium.org changed reviewers:
+ hidehiko@chromium.org

[hashimoto, 2016-10-12 09:50:04]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 09:50:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-10-12 09:59:07]

Only minor comments.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc:13:
ArcContentFileSystemAsyncFileUtil::ArcContentFileSystemAsyncFileUtil() {}
nit: s/{}/= default/
Ditto for below.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc:16:
: async_file_util_(new ArcContentFileSystemAsyncFileUtil) {}
() is encouraged to add: "new ...FileUtil()"

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc:18:
ArcContentFileSystemBackendDelegate::~ArcContentFileSystemBackendDelegate() {}
= default.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc:23:
return net::ERR_FAILED;
maybe net::ERR_NOT_IMPLEMENTED?

[hidehiko, 2016-10-12 09:59:07]

Only minor comments.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc:13:
ArcContentFileSystemAsyncFileUtil::ArcContentFileSystemAsyncFileUtil() {}
nit: s/{}/= default/
Ditto for below.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc:16:
: async_file_util_(new ArcContentFileSystemAsyncFileUtil) {}
() is encouraged to add: "new ...FileUtil()"

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc:18:
ArcContentFileSystemBackendDelegate::~ArcContentFileSystemBackendDelegate() {}
= default.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc:23:
return net::ERR_FAILED;
maybe net::ERR_NOT_IMPLEMENTED?

[commit-bot: I haz the power, 2016-10-12 10:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 10:02:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[hashimoto, 2016-10-12 10:08:11]

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc:13:
ArcContentFileSystemAsyncFileUtil::ArcContentFileSystemAsyncFileUtil() {}
On 2016/10/12 09:59:07, hidehiko wrote:
> nit: s/{}/= default/
> Ditto for below.

Done.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc:16:
: async_file_util_(new ArcContentFileSystemAsyncFileUtil) {}
On 2016/10/12 09:59:07, hidehiko wrote:
> () is encouraged to add: "new ...FileUtil()"

Done.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_backend_delegate.cc:18:
ArcContentFileSystemBackendDelegate::~ArcContentFileSystemBackendDelegate() {}
On 2016/10/12 09:59:07, hidehiko wrote:
> = default.

Done.

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
(right):

https://codereview.chromium.org/2411323002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc:23:
return net::ERR_FAILED;
On 2016/10/12 09:59:07, hidehiko wrote:
> maybe net::ERR_NOT_IMPLEMENTED?

Done.

[hashimoto, 2016-10-12 10:08:17]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 10:08:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 11:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 11:21:53]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-10-13 10:21:10]

lgtm

[hashimoto, 2016-10-13 14:02:20]

hashimoto@chromium.org changed reviewers:
+ satorux@chromium.org

[hashimoto, 2016-10-13 14:02:21]

satorux, could you review chrome/browser/chromeos/BUILD.gn?

[satorux1, 2016-10-13 14:08:16]

BUILD.gn LGTM.

I think we should allow anyone to review BUILD.gn. Can you update OWNERS file to
do that?

[hashimoto, 2016-10-13 14:21:07]

On 2016/10/13 14:08:16, satorux1 wrote:
> BUILD.gn LGTM.
> 
> I think we should allow anyone to review BUILD.gn. Can you update OWNERS file
to
> do that?

sg
I will make a CL for it tomorrow.

[hashimoto, 2016-10-13 14:21:21]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2016-10-13 14:21:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:12:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 15:16:51]

Description was changed from

==========
arc: Empty implementation of ARC content file system

Actual implementation will be added later.

BUG=654684
==========

to

==========
arc: Empty implementation of ARC content file system

Actual implementation will be added later.

BUG=654684

Committed: https://crrev.com/f506bdfec37f2e79353169d874b1eb8fbf155873
Cr-Commit-Position: refs/heads/master@{#425034}
==========

[commit-bot: I haz the power, 2016-10-13 15:16:52]

Patchset 2 (id:??) landed as
https://crrev.com/f506bdfec37f2e79353169d874b1eb8fbf155873
Cr-Commit-Position: refs/heads/master@{#425034}