Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 2411293002: Fix cross-renderer resource loads for <webview> with PlzNavigate. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index 9ae9a4c24ef2171c3ed7acf5d9e2cadd11e04743..9ed2fbb02392e347366f901d4f5725ac2e5d33f0 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -255,20 +255,8 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,
const content::WebContents* web_contents) const final;
// WebContentsObserver implementation.
- void DidCommitProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& url,
- ui::PageTransition transition_type) final;
- void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description,
- bool was_ignored_by_handler) final;
- void DidStartProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page,
- bool is_iframe_srcdoc) final;
+ void DidStartNavigation(content::NavigationHandle* navigation_handle) final;
+ void DidFinishNavigation(content::NavigationHandle* navigation_handle) final;
void RenderProcessGone(base::TerminationStatus status) final;
void UserAgentOverrideSet(const std::string& user_agent) final;
void FrameNameChanged(content::RenderFrameHost* render_frame_host,
@@ -308,10 +296,7 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,
// Notification that a load in the guest resulted in abort. Note that |url|
// may be invalid.
- void LoadAbort(bool is_top_level,
- const GURL& url,
- int error_code,
- const std::string& error_type);
+ void LoadAbort(bool is_top_level, const GURL& url, int error_code);
// Creates a new guest window owned by this WebViewGuest.
void CreateNewGuestWebViewWindow(const content::OpenURLParams& params);

Powered by Google App Engine
This is Rietveld 408576698