Fix cross-renderer resource loads for <webview> with PlzNavigate.

Fix cross-renderer resource loads for <webview> with PlzNavigate.

This is done by sharing the logic that ExtensionProtocolHandler does in ExtensionNavigationThrottle. The former doesn't have enough information for navigation requests since the process id isn't known, which is why the logic is shared into the extensions navigation throttle.

The other fix is to convert WebViewGuest to use the new navigation callbacks.

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347
Committed: https://crrev.com/6adb8c23bd7b3fe24398c5500a2f89c758e36a4d
Cr-Commit-Position: refs/heads/master@{#425073}

[jam, 2016-10-12 07:23:22]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 07:23:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 07:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 07:23:46]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[jam, 2016-10-12 15:13:56]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 15:14:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:14:10]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[jam, 2016-10-12 16:25:54]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 16:26:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 16:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 16:36:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2016-10-12 22:49:42]

Patchset #1 (id:1) has been deleted

[jam, 2016-10-12 23:54:24]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 23:54:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 00:02:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 00:02:18]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jam, 2016-10-13 01:18:39]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 01:18:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 01:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 01:29:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2016-10-13 03:22:08]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 03:22:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-10-13 03:24:25]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 03:24:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-10-13 04:02:42]

Patchset #4 (id:80001) has been deleted

[jam, 2016-10-13 04:03:13]

Patchset #2 (id:40001) has been deleted

[jam, 2016-10-13 05:46:40]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 05:47:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 06:20:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 06:20:47]

Dry run: This issue passed the CQ dry run.

[jam, 2016-10-13 06:24:17]

Description was changed from

==========
fix <webview> with plznavigate

BUG=
==========

to

==========
fix <webview> with plznavigate

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=
==========

[jam, 2016-10-13 15:15:11]

Description was changed from

==========
fix <webview> with plznavigate

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=
==========

to

==========
fix <webview> with plznavigate

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347
==========

[jam, 2016-10-13 15:15:12]

jam@chromium.org changed reviewers:
+ fsamuel@chromium.org

[jam, 2016-10-13 15:19:26]

Description was changed from

==========
fix <webview> with plznavigate

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347
==========

to

==========
Fix cross-renderer resource loads for <webview> with PlzNavigate.

This is done by sharing the logic that ExtensionProtocolHandler does in
ExtensionNavigationThrottle. The former doesn't have enough information for
navigation requests since the process id isn't known, which is why the logic is
shared into the extensions navigation throttle.

The other fix is to convert WebViewGuest to use the new navigation callbacks.

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347
==========

[Fady Samuel, 2016-10-13 15:33:02]

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/gue...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/gue...
extensions/browser/guest_view/web_view/web_view_guest.cc:819: :
net::ERR_BLOCKED_BY_CLIENT;
This would happen if the load is blocked by the webrequest API, presumably? A
comment would be nice, as someone looking back at this code would likely be
confused here I think.

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/url...
File extensions/browser/url_request_util.cc (right):

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/url...
extensions/browser/url_request_util.cc:49: if
(AllowCrossRendererResourceLoad(is_guest, extension, owner_extension,
Can we call this something else? It's a bit confusing to have two methods with
the same name and different signatures here with one calling the other.

[jam, 2016-10-13 16:30:06]

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/gue...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/gue...
extensions/browser/guest_view/web_view/web_view_guest.cc:819: :
net::ERR_BLOCKED_BY_CLIENT;
On 2016/10/13 15:33:01, Fady Samuel wrote:
> This would happen if the load is blocked by the webrequest API, presumably? A
> comment would be nice, as someone looking back at this code would likely be
> confused here I think.

Right. the error code ERR_BLOCKED_BY_CLIENT keeps the behavior the same between
IO/UI thread blocking.

Added comment

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/url...
File extensions/browser/url_request_util.cc (right):

https://codereview.chromium.org/2411293002/diff/120001/extensions/browser/url...
extensions/browser/url_request_util.cc:49: if
(AllowCrossRendererResourceLoad(is_guest, extension, owner_extension,
On 2016/10/13 15:33:01, Fady Samuel wrote:
> Can we call this something else? It's a bit confusing to have two methods with
> the same name and different signatures here with one calling the other. 

Done.

[jam, 2016-10-13 16:30:18]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 16:30:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 17:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:05:17]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-10-13 17:08:27]

lgtm

[jam, 2016-10-13 17:10:17]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:10:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 17:14:52]

Description was changed from

==========
Fix cross-renderer resource loads for <webview> with PlzNavigate.

This is done by sharing the logic that ExtensionProtocolHandler does in
ExtensionNavigationThrottle. The former doesn't have enough information for
navigation requests since the process id isn't known, which is why the logic is
shared into the extensions navigation throttle.

The other fix is to convert WebViewGuest to use the new navigation callbacks.

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347
==========

to

==========
Fix cross-renderer resource loads for <webview> with PlzNavigate.

This is done by sharing the logic that ExtensionProtocolHandler does in
ExtensionNavigationThrottle. The former doesn't have enough information for
navigation requests since the process id isn't known, which is why the logic is
shared into the extensions navigation throttle.

The other fix is to convert WebViewGuest to use the new navigation callbacks.

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347
==========

[commit-bot: I haz the power, 2016-10-13 17:14:53]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-10-13 17:17:28]

Description was changed from

==========
Fix cross-renderer resource loads for <webview> with PlzNavigate.

This is done by sharing the logic that ExtensionProtocolHandler does in
ExtensionNavigationThrottle. The former doesn't have enough information for
navigation requests since the process id isn't known, which is why the logic is
shared into the extensions navigation throttle.

The other fix is to convert WebViewGuest to use the new navigation callbacks.

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347
==========

to

==========
Fix cross-renderer resource loads for <webview> with PlzNavigate.

This is done by sharing the logic that ExtensionProtocolHandler does in
ExtensionNavigationThrottle. The former doesn't have enough information for
navigation requests since the process id isn't known, which is why the logic is
shared into the extensions navigation throttle.

The other fix is to convert WebViewGuest to use the new navigation callbacks.

This fixes
WebViewTests/WebViewPluginTest.TestLoadPluginInternalResource/*
WebViewTests/WebViewTest.Shim_TestInvalidChromeExtensionURL/*
WebViewTests/WebViewTest.Shim_TestLoadAbortChromeExtensionURLWrongPartition/*
WebViewTests/WebViewTest.Shim_TestLoadAbortEmptyResponse/*
WebViewTests/WebViewTest.Shim_TestLoadStartLoadRedirect/*
with plzNavigate

BUG=504347

Committed: https://crrev.com/6adb8c23bd7b3fe24398c5500a2f89c758e36a4d
Cr-Commit-Position: refs/heads/master@{#425073}
==========

[commit-bot: I haz the power, 2016-10-13 17:17:29]

Patchset 5 (id:??) landed as
https://crrev.com/6adb8c23bd7b3fe24398c5500a2f89c758e36a4d
Cr-Commit-Position: refs/heads/master@{#425073}