Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: src/compiler/js-native-context-specialization.cc

Issue 2411273002: [turbofan] Fix effect chain for polymorphic array access. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-655004.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-native-context-specialization.h" 5 #include "src/compiler/js-native-context-specialization.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/compilation-dependencies.h" 9 #include "src/compilation-dependencies.h"
10 #include "src/compiler/access-builder.h" 10 #include "src/compiler/access-builder.h"
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 check = graph()->NewNode(simplified()->CheckIf(), check, 597 check = graph()->NewNode(simplified()->CheckIf(), check,
598 this_effect, this_control); 598 this_effect, this_control);
599 this_controls.push_back(this_control); 599 this_controls.push_back(this_control);
600 this_effects.push_back(check); 600 this_effects.push_back(check);
601 fallthrough_control = nullptr; 601 fallthrough_control = nullptr;
602 } else { 602 } else {
603 Node* branch = graph()->NewNode(common()->Branch(), check, 603 Node* branch = graph()->NewNode(common()->Branch(), check,
604 fallthrough_control); 604 fallthrough_control);
605 this_controls.push_back( 605 this_controls.push_back(
606 graph()->NewNode(common()->IfTrue(), branch)); 606 graph()->NewNode(common()->IfTrue(), branch));
607 this_effects.push_back(effect); 607 this_effects.push_back(this_effect);
608 fallthrough_control = 608 fallthrough_control =
609 graph()->NewNode(common()->IfFalse(), branch); 609 graph()->NewNode(common()->IfFalse(), branch);
610 } 610 }
611 } 611 }
612 612
613 // Create single chokepoint for the control. 613 // Create single chokepoint for the control.
614 int const this_control_count = static_cast<int>(this_controls.size()); 614 int const this_control_count = static_cast<int>(this_controls.size());
615 if (this_control_count == 1) { 615 if (this_control_count == 1) {
616 this_control = this_controls.front(); 616 this_control = this_controls.front();
617 this_effect = this_effects.front(); 617 this_effect = this_effects.front();
(...skipping 885 matching lines...) Expand 10 before | Expand all | Expand 10 after
1503 return jsgraph()->javascript(); 1503 return jsgraph()->javascript();
1504 } 1504 }
1505 1505
1506 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const { 1506 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const {
1507 return jsgraph()->simplified(); 1507 return jsgraph()->simplified();
1508 } 1508 }
1509 1509
1510 } // namespace compiler 1510 } // namespace compiler
1511 } // namespace internal 1511 } // namespace internal
1512 } // namespace v8 1512 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-655004.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698