Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2411273002: [turbofan] Fix effect chain for polymorphic array access. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix effect chain for polymorphic array access. We accidently dropped the effect on the floor that we have for the polymorphic map check in case of array elements access. BUG=chromium:655004 R=jarin@chromium.org Committed: https://crrev.com/edfe391ef57ef6d1e4a5ce44e20b8361112196a2 Cr-Commit-Position: refs/heads/master@{#40201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-655004.js View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-12 07:05:18 UTC) #1
Jarin
lgtm
4 years, 2 months ago (2016-10-12 07:11:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411273002/1
4 years, 2 months ago (2016-10-12 08:29:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 08:31:47 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 08:32:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edfe391ef57ef6d1e4a5ce44e20b8361112196a2
Cr-Commit-Position: refs/heads/master@{#40201}

Powered by Google App Engine
This is Rietveld 408576698