[WeakMemoryCache] Remove LRU lists, prune order control and live/dead distinction

third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/fetch/CSSStyleSheetResource.h"
 
 #include "core/css/CSSCrossfadeValue.h"
 #include "core/css/CSSImageValue.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/CSSProperty.h"
@@ skipping 42 matching lines @@
   ~CSSStyleSheetResourceTest() override {
     replaceMemoryCacheForTesting(m_originalMemoryCache.release());
   }
 
   Document& document() { return m_page->document(); }
 
   Persistent<MemoryCache> m_originalMemoryCache;
   std::unique_ptr<DummyPageHolder> m_page;
 };
 
 TEST_F(CSSStyleSheetResourceTest, PruneCanCauseEviction) {

[yhirano, 2016/10/24 08:14:00]

According to https://codereview.chromium.org/1537343002 this test is meaningless
without the deleted lines. Maybe you can remove the entire test case.

[hiroshige, 2016/10/24 10:48:25]

Done.

   {
     // We need this scope to remove all references.
     KURL imageURL(KURL(), "https://localhost/image");
     KURL cssURL(KURL(), "https://localhost/style.css");
 
     // We need to disable loading because we manually give a response to
     // the image resource.
     document().fetcher()->setAutoLoadImages(false);
 
     CSSStyleSheetResource* cssResource =
@@ skipping 24 matching lines @@
     Resource* imageResource = memoryCache()->resourceForURL(
         imageURL, MemoryCache::defaultCacheIdentifier());
     ASSERT_TRUE(imageResource);
     ResourceResponse imageResponse;
     imageResponse.setURL(imageURL);
     imageResponse.setHTTPHeaderField("cache-control", "no-store");
     imageResource->responseReceived(imageResponse, nullptr);
 
     contents->checkLoaded();
     cssResource->saveParsedStyleSheet(contents);
-
-    memoryCache()->update(cssResource, cssResource->size(), cssResource->size(),
-                          false);
-    memoryCache()->update(imageResource, imageResource->size(),
-                          imageResource->size(), false);
-    if (!memoryCache()->isInSameLRUListForTest(cssResource, imageResource)) {
-      // We assume that the LRU list is determined by |size / accessCount|.
-      for (size_t i = 0; i < cssResource->size() + 1; ++i)
-        memoryCache()->update(cssResource, cssResource->size(),
-                              cssResource->size(), true);
-      for (size_t i = 0; i < imageResource->size() + 1; ++i)
-        memoryCache()->update(imageResource, imageResource->size(),
-                              imageResource->size(), true);
-    }
-    ASSERT_TRUE(
-        memoryCache()->isInSameLRUListForTest(cssResource, imageResource));
   }
   ThreadState::current()->collectAllGarbage();
   // This operation should not lead to crash!
   memoryCache()->pruneAll();
 }
 
 TEST_F(CSSStyleSheetResourceTest, DuplicateResourceNotCached) {
   const char url[] = "https://localhost/style.css";
   KURL imageURL(KURL(), url);
   KURL cssURL(KURL(), url);
@@ skipping 23 matching lines @@
   // The underlying |contents| for the stylesheet resource must have a
   // matching reference status.
   EXPECT_TRUE(memoryCache()->contains(imageResource));
   EXPECT_FALSE(memoryCache()->contains(cssResource));
   EXPECT_FALSE(contents->isReferencedFromResource());
   EXPECT_FALSE(cssResource->restoreParsedStyleSheet(parserContext));
 }
 
 }  // namespace
 }  // namespace blink