Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json

Issue 2411243003: Revert of Download the hermetic xcode toolchain on all bots that target mac. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json
diff --git a/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json b/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json
index 05c297ab31a8433d09f04659a4cddb73f1c79180..aee3814b6c4caf5e1ed05d1c567df8e8b5f98587 100644
--- a/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json
+++ b/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json
@@ -118,7 +118,6 @@
],
"cwd": "[SLAVE_BUILD]/v8",
"env": {
- "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
"GYP_CHROMIUM_NO_ACTION": "1",
"GYP_DEFINES": "clang=1 gomadir='[CACHE]/cipd/goma' target_arch=ia32 use_goma=1 v8_enable_disassembler=1 v8_target_arch=ia32",
@@ -157,7 +156,6 @@
],
"cwd": "[SLAVE_BUILD]/v8",
"env": {
- "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "generate_build_files",
@@ -219,7 +217,6 @@
],
"cwd": "[SLAVE_BUILD]/v8",
"env": {
- "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "generate_build_files with gn (fyi)"
@@ -257,7 +254,6 @@
"/path/to/tmp/json"
],
"env": {
- "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "clang_revision",
@@ -305,7 +301,6 @@
"--"
],
"env": {
- "FORCE_MAC_TOOLCHAIN": "1",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
"name": "compile",

Powered by Google App Engine
This is Rietveld 408576698