scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json - Issue 2411243003: Revert of Download the hermetic xcode toolchain on all bots that target mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json

Issue 2411243003: Revert of Download the hermetic xcode toolchain on all bots that target mac. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json b/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json

index e05eaa99e191768e0129f3ffa036aca8f8683e91..bc05e49bb10d31db62683219605df8057d600f69 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder__dbg_.json

@@ -200,7 +200,6 @@

"cwd": "[BUILDER_CACHE]/mac_layout/src",

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

"GYP_DEFINES": "clang=1 component=shared_library gomadir='[CACHE]/cipd/goma' target_arch=x64 test_isolation_mode=prepare use_goma=1",

@@ -297,7 +296,6 @@

"cwd": "[BUILDER_CACHE]/mac_layout/src",

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "generate_build_files",

@@ -318,7 +316,6 @@

"/path/to/tmp/json"

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "clang_revision",

@@ -371,7 +368,6 @@

"browser_tests_run"

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "compile",