scripts/slave/recipes/chromium.expected/full_chromium_Mac.json - Issue 2411243003: Revert of Download the hermetic xcode toolchain on all bots that target mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_Mac.json

Issue 2411243003: Revert of Download the hermetic xcode toolchain on all bots that target mac. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_Mac.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_Mac.json b/scripts/slave/recipes/chromium.expected/full_chromium_Mac.json

index 45f4de23b28a2fb231608a9f48a42484bdcfb2a6..d700938020d1ec8c76596cb3781b09e8b77b12e7 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_Mac.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_Mac.json

@@ -206,7 +206,6 @@

"cwd": "[BUILDER_CACHE]/mac_ng/src",

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

"GYP_DEFINES": "clang=1 component=static_library gomadir='[CACHE]/cipd/goma' linux_dump_symbols=0 target_arch=x64 test_isolation_mode=noop use_goma=1",

@@ -279,7 +278,6 @@

"cwd": "[BUILDER_CACHE]/mac_ng/src",

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "generate_build_files"

@@ -296,7 +294,6 @@

"/path/to/tmp/json"

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "clang_revision",

@@ -348,7 +345,6 @@

"all"

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "compile",