Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2411183004: Use correct index when recording data reduction proxy server stats. (Closed)

Created:
4 years, 2 months ago by Bernhard Bauer
Modified:
4 years, 2 months ago
Reviewers:
tbansal1
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct index when recording data reduction proxy server stats. Contrary to appearances, the |proxy_index| in DataReductionProxyTypeInfo is not actually an index into |proxy_servers|, it's the index at which the |proxy_servers| *start* in the overall list of proxies. This means that using |proxy_index| will work as long as the used proxy is in the first half of the list, but will crash if it's in the second half. BUG=655580 Committed: https://crrev.com/741effdd4161d13f86ed8e73c2e16f9628e7466d Cr-Commit-Position: refs/heads/master@{#425092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Bernhard Bauer
Please review.
4 years, 2 months ago (2016-10-13 15:19:07 UTC) #4
tbansal1
lgtm. Thanks for fixing this.
4 years, 2 months ago (2016-10-13 16:17:51 UTC) #5
tbansal1
Can you set the BUG to 655580? I am going to assign that bug to ...
4 years, 2 months ago (2016-10-13 16:19:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411183004/1
4 years, 2 months ago (2016-10-13 18:10:56 UTC) #11
tbansal1
Since it might be late in bauerb's timezone, and the bug is Dev release blocking, ...
4 years, 2 months ago (2016-10-13 18:12:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 18:17:25 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/741effdd4161d13f86ed8e73c2e16f9628e7466d Cr-Commit-Position: refs/heads/master@{#425092}
4 years, 2 months ago (2016-10-13 18:20:10 UTC) #16
Bernhard Bauer
4 years, 2 months ago (2016-10-14 07:51:41 UTC) #17
Message was sent while issue was closed.
On 2016/10/13 18:20:10, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/741effdd4161d13f86ed8e73c2e16f9628e7466d
> Cr-Commit-Position: refs/heads/master@{#425092}

Thanks for fixing up the BUG ID!

Powered by Google App Engine
This is Rietveld 408576698