Make reloadSources service RPC public

Make reloadSources service RPC public

- [x] Make `reloadSources` RPC public.
- [x] Add an optional 'pause' parameter to `reloadSources`. When set to true, the isolate will enter the debug pause loop immediately after reloading sources and before resuming execution. This makes it possible for debugger clients to set breakpoints before resuming.
- [x] Add reload_sources_test which tests pausing after reload.
- [x] Fix a bug in `GetVarDescriptors` where a null code object could be used.

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d0a08baf95a4261a6788fe17b899fb55f6c5a58

[Cutch, 2016-10-11 23:09:36]

Description was changed from

==========
Make reloadSources service RPC public

BUG=
==========

to

==========
Make reloadSources service RPC public

- [x] Make `reloadSources` RPC public.
- [x] Add an optional 'pause' parameter to `reloadSources`. When set to true,
the isolate will enter the debug pause loop immediately after reloading sources
and before resuming execution. This makes it possible for debugger clients to
set breakpoints before resuming.
- [x] Add reload_sources_test which tests pausing after reload.
- [x] Fix a bug in `GetVarDescriptors` where a null code object could be used.
==========

[Cutch, 2016-10-11 23:09:36]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2016-10-12 02:57:23]

lgtm w/ 1 comment

https://codereview.chromium.org/2411153002/diff/1/runtime/vm/service_event.h
File runtime/vm/service_event.h (right):

https://codereview.chromium.org/2411153002/diff/1/runtime/vm/service_event.h#...
runtime/vm/service_event.h:40: kPausePostReload,    // isolate is paused after a
reload.
If we rename this event something like "PausePostRequest" in the public api,
then we can reuse it in the future for other requests which support the "pause"
parameter.

[Cutch, 2016-10-13 01:48:55]

https://codereview.chromium.org/2411153002/diff/1/runtime/vm/service_event.h
File runtime/vm/service_event.h (right):

https://codereview.chromium.org/2411153002/diff/1/runtime/vm/service_event.h#...
runtime/vm/service_event.h:40: kPausePostReload,    // isolate is paused after a
reload.
On 2016/10/12 02:57:23, turnidge wrote:
> If we rename this event something like "PausePostRequest" in the public api,
> then we can reuse it in the future for other requests which support the
"pause"
> parameter.

Done.

[devoncarew, 2016-10-13 14:25:00]

devoncarew@google.com changed reviewers:
+ devoncarew@google.com

[devoncarew, 2016-10-13 14:25:01]

DBC: the new PausePostRequestEvent and the reloadSources call should be added to
the service.md doc. The event in particular will be useful to clients that
generate their library from the docs.

[Cutch, 2016-10-13 14:42:34]

On 2016/10/13 14:25:01, devoncarew wrote:
> DBC: the new PausePostRequestEvent and the reloadSources call should be added
to
> the service.md doc. The event in particular will be useful to clients that
> generate their library from the docs.

Updated service.md will follow shortly. Still nailing down the response
structure for reloadSources.

[Cutch, 2016-10-13 14:46:02]

Description was changed from

==========
Make reloadSources service RPC public

- [x] Make `reloadSources` RPC public.
- [x] Add an optional 'pause' parameter to `reloadSources`. When set to true,
the isolate will enter the debug pause loop immediately after reloading sources
and before resuming execution. This makes it possible for debugger clients to
set breakpoints before resuming.
- [x] Add reload_sources_test which tests pausing after reload.
- [x] Fix a bug in `GetVarDescriptors` where a null code object could be used.
==========

to

==========
Make reloadSources service RPC public

- [x] Make `reloadSources` RPC public.
- [x] Add an optional 'pause' parameter to `reloadSources`. When set to true,
the isolate will enter the debug pause loop immediately after reloading sources
and before resuming execution. This makes it possible for debugger clients to
set breakpoints before resuming.
- [x] Add reload_sources_test which tests pausing after reload.
- [x] Fix a bug in `GetVarDescriptors` where a null code object could be used.

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2d0a08baf95a4261a6788fe17b899fb55f6c5a58
==========

[Cutch, 2016-10-13 14:46:03]

Committed patchset #2 (id:20001) manually as
2d0a08baf95a4261a6788fe17b899fb55f6c5a58 (presubmit successful).