Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2411123003: Fix else-line corrupted by non-ascii characters when import (Closed)

Created:
4 years, 2 months ago by kcwu
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix else-line corrupted by non-ascii character when import BUG=pdfium:619 Committed: https://pdfium.googlesource.com/pdfium/+/7dd285df25630482bfd7bceea3678ff1dc60aab5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/lcms2-2.6/src/cmsxform.c View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
kcwu
4 years, 2 months ago (2016-10-12 06:41:00 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2411123003/diff/1/third_party/lcms2-2.6/src/cmsxform.c File third_party/lcms2-2.6/src/cmsxform.c (right): https://codereview.chromium.org/2411123003/diff/1/third_party/lcms2-2.6/src/cmsxform.c#newcode697 third_party/lcms2-2.6/src/cmsxform.c:697: p ->xform = PrecalculatedXFORMGamutCheck; // Gamut check, no ...
4 years, 2 months ago (2016-10-12 06:48:24 UTC) #3
kcwu
On 2016/10/12 06:48:24, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/2411123003/diff/1/third_party/lcms2-2.6/src/cmsxform.c > File third_party/lcms2-2.6/src/cmsxform.c (right): ...
4 years, 2 months ago (2016-10-12 06:55:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411123003/1
4 years, 2 months ago (2016-10-12 07:03:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/7dd285df25630482bfd7bceea3678ff1dc60aab5
4 years, 2 months ago (2016-10-12 07:16:23 UTC) #8
Lei Zhang
4 years, 2 months ago (2016-10-12 07:31:24 UTC) #9
Message was sent while issue was closed.
On 2016/10/12 06:55:07, kcwu wrote:
> I'm afraid that some compilers may be unhappy with é at eol, so I'd prefer not
> touch them.

I was just thinking of a regular 'e' ...

Powered by Google App Engine
This is Rietveld 408576698