Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 2411093002: Always keep a ChannelProxy alive in RenderProcessHostImpl (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index f97cd70afc3b22d9cb4f2afe1a07f375661456ca..5cefd4e84877bc55847528bfbe1a7908a46877a3 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -114,7 +114,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
~RenderProcessHostImpl() override;
// RenderProcessHost implementation (public portion).
- void EnableSendQueue() override;
bool Init() override;
int GetNextRoutingID() override;
void AddRoute(int32_t routing_id, IPC::Listener* listener) override;
@@ -307,7 +306,9 @@ class CONTENT_EXPORT RenderProcessHostImpl
return service_worker_ref_count_ + shared_worker_ref_count_;
}
- std::unique_ptr<IPC::ChannelProxy> CreateChannelProxy();
+ // Initializes a new IPC::ChannelProxy in |channel_|, which will be connected
+ // to the next child process launched for this host, if any.
+ void InitializeChannelProxy();
// Creates and adds the IO thread message filters.
void CreateMessageFilters();
@@ -458,9 +459,11 @@ class CONTENT_EXPORT RenderProcessHostImpl
// Used in single-process mode.
std::unique_ptr<base::Thread> in_process_renderer_;
- // True after Init() has been called. We can't just check channel_ because we
- // also reset that in the case of process termination.
- bool is_initialized_;
+ // True after Init() has been called.
+ bool is_initialized_ = false;
+
+ // True after ProcessDied(), until the next call to Init().
+ bool is_dead_ = false;
// PlzNavigate
// Stores the time at which the first call to Init happened.
@@ -469,10 +472,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
// Used to launch and terminate the process without blocking the UI thread.
std::unique_ptr<ChildProcessLauncher> child_process_launcher_;
- // Messages we queue before the ChannelProxy is created.
- using MessageQueue = std::queue<std::unique_ptr<IPC::Message>>;
- MessageQueue queued_messages_;
-
// The globally-unique identifier for this RPH.
const int id_;
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698