net/socket/ssl_server_socket_unittest.cc - Issue 2411033003: Drop buffers in idle SSLClientSockets (and SSLServerSockets).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_server_socket_unittest.cc

Issue 2411033003: Drop buffers in idle SSLClientSockets (and SSLServerSockets). (Closed)

Patch Set: rsleevi comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_server_socket_unittest.cc

diff --git a/net/socket/ssl_server_socket_unittest.cc b/net/socket/ssl_server_socket_unittest.cc

index 82c8f35171a583b302dd28c63d06274a33206309..1db50b9e5d051625690611142ea27978ccfb50d6 100644

--- a/net/socket/ssl_server_socket_unittest.cc

+++ b/net/socket/ssl_server_socket_unittest.cc

@@ -785,7 +785,8 @@ TEST_F(SSLServerSocketTest, HandshakeWithClientCertRequiredNotSupplied) {

client_socket_->Disconnect();

- EXPECT_THAT(handshake_callback.GetResult(server_ret), IsError(ERR_FAILED));

+ EXPECT_THAT(handshake_callback.GetResult(server_ret),

+ IsError(ERR_CONNECTION_CLOSED));

}

TEST_F(SSLServerSocketTest, HandshakeWithClientCertRequiredNotSuppliedCached) {

@@ -818,7 +819,8 @@ TEST_F(SSLServerSocketTest, HandshakeWithClientCertRequiredNotSuppliedCached) {

client_socket_->Disconnect();

- EXPECT_THAT(handshake_callback.GetResult(server_ret), IsError(ERR_FAILED));

+ EXPECT_THAT(handshake_callback.GetResult(server_ret),

+ IsError(ERR_CONNECTION_CLOSED));

server_socket_->Disconnect();

// Below, check that the cache didn't store the result of a failed handshake.

@@ -840,7 +842,8 @@ TEST_F(SSLServerSocketTest, HandshakeWithClientCertRequiredNotSuppliedCached) {

client_socket_->Disconnect();

- EXPECT_THAT(handshake_callback2.GetResult(server_ret2), IsError(ERR_FAILED));

+ EXPECT_THAT(handshake_callback2.GetResult(server_ret2),

+ IsError(ERR_CONNECTION_CLOSED));

}

TEST_F(SSLServerSocketTest, HandshakeWithWrongClientCertSupplied) {

« no previous file with comments | « net/socket/ssl_server_socket_impl.cc ('k') | net/ssl/openssl_ssl_util.h » ('j') | no next file with comments »