Drop buffers in idle SSLClientSockets (and SSLServerSockets).

net/socket/ssl_client_socket_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_IMPL_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_IMPL_H_
 
 #include <openssl/base.h>
 #include <openssl/ssl.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/containers/mru_cache.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "build/build_config.h"
 #include "net/base/completion_callback.h"
 #include "net/base/io_buffer.h"
 #include "net/cert/cert_verifier.h"
 #include "net/cert/cert_verify_result.h"
 #include "net/cert/ct_verify_result.h"
 #include "net/log/net_log_with_source.h"
 #include "net/socket/client_socket_handle.h"
+#include "net/socket/socket_bio_adapter.h"
 #include "net/socket/ssl_client_socket.h"
 #include "net/ssl/channel_id_service.h"
 #include "net/ssl/openssl_ssl_util.h"
 #include "net/ssl/ssl_client_cert_type.h"
 #include "net/ssl/ssl_config_service.h"
 
 namespace base {
 class FilePath;
 class SequencedTaskRunner;
 }
 
 namespace crypto {
 class OpenSSLErrStackTracer;
 }
 
 namespace net {
 
 class CertVerifier;
 class CTVerifier;
+class SocketBIOAdapter;
 class SSLCertRequestInfo;
 class SSLInfo;
 
 using TokenBindingSignatureMap =
     base::MRUCache<std::pair<TokenBindingType, std::string>,
                    std::vector<uint8_t>>;
 
-class SSLClientSocketImpl : public SSLClientSocket {
+class SSLClientSocketImpl : public SSLClientSocket,
+                            public SocketBIOAdapter::Delegate {
  public:
   // Takes ownership of the transport_socket, which may already be connected.
   // The given hostname will be compared with the name(s) in the server's
   // certificate during the SSL handshake.  ssl_config specifies the SSL
   // settings.
   SSLClientSocketImpl(std::unique_ptr<ClientSocketHandle> transport_socket,
                       const HostPortPair& host_and_port,
                       const SSLConfig& ssl_config,
                       const SSLClientSocketContext& context);
   ~SSLClientSocketImpl() override;
@@ skipping 48 matching lines @@
   // Socket implementation.
   int Read(IOBuffer* buf,
            int buf_len,
            const CompletionCallback& callback) override;
   int Write(IOBuffer* buf,
             int buf_len,
             const CompletionCallback& callback) override;
   int SetReceiveBufferSize(int32_t size) override;
   int SetSendBufferSize(int32_t size) override;
 
+  // SocketBIOAdapter implementation:
+  void OnReadReady() override;
+  void OnWriteReady() override;
+
  private:
   class PeerCertificateChain;
   class SSLContext;
   friend class SSLClientSocket;
   friend class SSLContext;
 
   int Init();
   void DoReadCallback(int result);
   void DoWriteCallback(int result);
 
-  bool DoTransportIO();
   int DoHandshake();
   int DoHandshakeComplete(int result);
   int DoChannelIDLookup();
   int DoChannelIDLookupComplete(int result);
   int DoVerifyCert(int result);
   int DoVerifyCertComplete(int result);
   void DoConnectCallback(int result);
   void UpdateServerCert();
 
   void OnHandshakeIOComplete(int result);
-  void OnSendComplete(int result);
-  void OnRecvComplete(int result);
 
   int DoHandshakeLoop(int last_io_result);
-  int DoReadLoop();
-  int DoWriteLoop();
   int DoPayloadRead();
   int DoPayloadWrite();
 
   // Called when an asynchronous event completes which may have blocked the
-  // pending Read or Write calls, if any. Retries both state machines and, if
-  // complete, runs the respective callbacks.
-  void PumpReadWriteEvents();
+  // pending Connect, Read or Write calls, if any. Retries all state machines
+  // and, if complete, runs the respective callbacks.
+  void RetryAllOperations();
 
-  int BufferSend();
-  int BufferRecv();
-  void BufferSendComplete(int result);
-  void BufferRecvComplete(int result);
-  void TransportWriteComplete(int result);
-  int TransportReadComplete(int result);
   int VerifyCT();
 
   // Callback from the SSL layer that indicates the remote server is requesting
   // a certificate for this client.
   int ClientCertRequestCallback(SSL* ssl);
 
   // CertVerifyCallback is called to verify the server's certificates. We do
   // verification after the handshake so this function only enforces that the
   // certificates don't change during renegotiation.
   int CertVerifyCallback(X509_STORE_CTX* store_ctx);
 
-  // Called during an operation on |transport_bio_|'s peer. Checks saved
-  // transport error state and, if appropriate, returns an error through
-  // OpenSSL's error system.
-  long MaybeReplayTransportError(BIO* bio,
-                                 int cmd,
-                                 const char* argp,
-                                 int argi,
-                                 long argl,
-                                 long retvalue);
-
-  // Callback from the SSL layer when an operation is performed on
-  // |transport_bio_|'s peer.
-  static long BIOCallback(BIO* bio,
-                          int cmd,
-                          const char* argp,
-                          int argi,
-                          long argl,
-                          long retvalue);
-
   // Called after the initial handshake completes and after the server
   // certificate has been verified. The order of handshake completion and
   // certificate verification depends on whether the connection was false
   // started. After both have happened (thus calling this twice), the session is
   // safe to cache and will be cached.
   void MaybeCacheSession();
 
   // Called from the SSL layer whenever a new session is established.
   int NewSessionCallback(SSL_SESSION* session);
 
@@ skipping 46 matching lines @@
 
   // Returns whether TLS channel ID is enabled.
   bool IsChannelIDEnabled() const;
 
   // Returns the net error corresponding to the most recent OpenSSL
   // error. ssl_error is the output of SSL_get_error.
   int MapLastOpenSSLError(int ssl_error,
                           const crypto::OpenSSLErrStackTracer& tracer,
                           OpenSSLErrorInfo* info);
 
-  bool transport_send_busy_;
-  bool transport_recv_busy_;
-
-  // Buffers which are shared by BoringSSL and SSLClientSocketImpl.
-  // GrowableIOBuffer is used to keep ownership and setting offset.
-  scoped_refptr<GrowableIOBuffer> send_buffer_;
-  scoped_refptr<GrowableIOBuffer> recv_buffer_;
-
   CompletionCallback user_connect_callback_;
   CompletionCallback user_read_callback_;
   CompletionCallback user_write_callback_;
 
   // Used by Read function.
   scoped_refptr<IOBuffer> user_read_buf_;
   int user_read_buf_len_;
 
   // Used by Write function.
   scoped_refptr<IOBuffer> user_write_buf_;
   int user_write_buf_len_;
 
   // Used by DoPayloadRead() when attempting to fill the caller's buffer with
   // as much data as possible without blocking.
   // If DoPayloadRead() encounters an error after having read some data, stores
   // the result to return on the *next* call to DoPayloadRead().  A value > 0
   // indicates there is no pending result, otherwise 0 indicates EOF and < 0
   // indicates an error.
   int pending_read_error_;
 
   // If there is a pending read result, the OpenSSL result code (output of
   // SSL_get_error) associated with it.
   int pending_read_ssl_error_;
 
   // If there is a pending read result, the OpenSSLErrorInfo associated with it.
   OpenSSLErrorInfo pending_read_error_info_;
 
-  // Used by TransportReadComplete() to signify an error reading from the
-  // transport socket. A value of OK indicates the socket is still
-  // readable. EOFs are mapped to ERR_CONNECTION_CLOSED.
-  int transport_read_error_;
-
-  // Used by TransportWriteComplete() and TransportReadComplete() to signify an
-  // error writing to the transport socket. A value of OK indicates no error.
-  int transport_write_error_;
-
   // Set when Connect finishes.
   std::unique_ptr<PeerCertificateChain> server_cert_chain_;
   scoped_refptr<X509Certificate> server_cert_;
   CertVerifyResult server_cert_verify_result_;
   std::string ocsp_response_;
   bool completed_connect_;
 
   // Set when Read() or Write() successfully reads or writes data to or from the
   // network.
   bool was_ever_used_;
@@ skipping 14 matching lines @@
   CTVerifier* cert_transparency_verifier_;
 
   // The service for retrieving Channel ID keys.  May be NULL.
   ChannelIDService* channel_id_service_;
   bool tb_was_negotiated_;
   TokenBindingParam tb_negotiated_param_;
   TokenBindingSignatureMap tb_signature_map_;
 
   // OpenSSL stuff
   bssl::UniquePtr<SSL> ssl_;
-  bssl::UniquePtr<BIO> transport_bio_;
 
   std::unique_ptr<ClientSocketHandle> transport_;
+  std::unique_ptr<SocketBIOAdapter> transport_adapter_;
   const HostPortPair host_and_port_;
   SSLConfig ssl_config_;
   // ssl_session_cache_shard_ is an opaque string that partitions the SSL
   // session cache. i.e. sessions created with one value will not attempt to
   // resume on the socket with a different value.
   const std::string ssl_session_cache_shard_;
 
   enum State {
     STATE_NONE,
     STATE_HANDSHAKE,
@@ skipping 38 matching lines @@
   // True if PKP is bypassed due to a local trust anchor.
   bool pkp_bypassed_;
 
   NetLogWithSource net_log_;
   base::WeakPtrFactory<SSLClientSocketImpl> weak_factory_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_IMPL_H_