Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2411023002: *WIP* Mac Unittest for client cert selection with intermediate certs

Created:
4 years, 2 months ago by mattm
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

*WIP* Mac Unittest for client cert selection with intermediate certs (generalizing ClientCertStoreNSSTest.BuildsCertificateChain) BUG=651962

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : blah #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -69 lines) Patch
M net/cert/cert_verify_proc_mac.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M net/cert/test_keychain_search_list_mac.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/test_keychain_search_list_mac.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/data/ssl/certificates/README View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/client_1.keychain View 1 2 3 4 Binary file 0 comments Download
A net/data/ssl/certificates/client_1_ca.keychain View 1 2 3 4 Binary file 0 comments Download
A net/data/ssl/scripts/generate-client-certificates-keychains.sh View 1 1 chunk +22 lines, -0 lines 0 comments Download
M net/data/ssl/scripts/generate-keychain.sh View 1 1 chunk +15 lines, -5 lines 0 comments Download
M net/ssl/client_cert_store_mac.cc View 1 2 3 8 chunks +95 lines, -3 lines 0 comments Download
M net/ssl/client_cert_store_mac_unittest.cc View 1 2 3 2 chunks +64 lines, -0 lines 0 comments Download
M net/ssl/client_cert_store_nss_unittest.cc View 1 chunk +37 lines, -54 lines 0 comments Download
M net/ssl/client_cert_store_unittest-inl.h View 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
mattm
The CQ bit was checked by mattm@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-11 23:06:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411023002/40001
4 years, 2 months ago (2016-10-11 23:06:51 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-12 00:05:04 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 00:05:05 UTC) #4
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698